Date: Sun, 4 Sep 2016 21:31:19 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305392 - head/sys/conf Message-ID: <D294D78E-6C86-4AA2-B804-DF55D431AA91@FreeBSD.org> In-Reply-To: <CAG6CVpU%2BeWvmdC-VzZ6jtQaUydsH4=9NNao8XPu2fSr0LYDgqQ@mail.gmail.com> References: <201609041755.u84HtMa5060050@repo.freebsd.org> <CAG6CVpU%2BeWvmdC-VzZ6jtQaUydsH4=9NNao8XPu2fSr0LYDgqQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 04 Sep 2016, at 20:57, Conrad Meyer <cem@FreeBSD.org> wrote: > > On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric <dim@freebsd.org> wrote: >> Author: dim >> Date: Sun Sep 4 17:55:22 2016 >> New Revision: 305392 >> URL: https://svnweb.freebsd.org/changeset/base/305392 >> >> Log: >> For kernel builds, instead of suppressing certain clang warnings, make >> them non-fatal, so there is some incentive to fix them eventually. >> >> Modified: >> head/sys/conf/kern.mk >> >> Modified: head/sys/conf/kern.mk >> ============================================================================== >> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 (r305391) >> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 (r305392) >> @@ -17,13 +17,13 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wn >> # kernel where fixing them is more trouble than it is worth, or where there is >> # a false positive. >> .if ${COMPILER_TYPE} == "clang" >> -NO_WCONSTANT_CONVERSION= -Wno-constant-conversion >> -NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative >> -NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow >> -NO_WSELF_ASSIGN= -Wno-self-assign >> -NO_WUNNEEDED_INTERNAL_DECL= -Wno-unneeded-internal-declaration >> +NO_WCONSTANT_CONVERSION= -Wno-error-constant-conversion >> +NO_WSHIFT_COUNT_NEGATIVE= -Wno-error-shift-count-negative >> +NO_WSHIFT_COUNT_OVERFLOW= -Wno-error-shift-count-overflow >> +NO_WSELF_ASSIGN= -Wno-error-self-assign >> +NO_WUNNEEDED_INTERNAL_DECL= -Wno-error-unneeded-internal-declaration >> NO_WSOMETIMES_UNINITIALIZED= -Wno-error-sometimes-uninitialized >> -NO_WCAST_QUAL= -Wno-cast-qual >> +NO_WCAST_QUAL= -Wno-error-cast-qual > > I like goal of the change. Shouldn't these be -Wno-error=cast-qual, > etc., though? That's how gcc spells them. Clang accepts both forms, there is no functional difference. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlfMdowACgkQsF6jCi4glqPnhACdFylP/bc8HHq32x9433fJ/5/8 nTAAoMICtdS+0AMgU0F+hmi/ZXbwNn2H =SbgV -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D294D78E-6C86-4AA2-B804-DF55D431AA91>