Date: Sat, 05 Jul 2014 21:26:45 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191641] New: patch(1) may misapply diffs missing final line feed Message-ID: <bug-191641-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191641 Bug ID: 191641 Summary: patch(1) may misapply diffs missing final line feed Product: Base System Version: 10.0-RELEASE Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: gavin@FreeBSD.org I believe that this is unrelated to bug 74127. "patch 2.0-12u10 FreeBSD" may sometimes duplicate the previous line when it should actually insert a blank line. This is reproduceable, for example, t= ry applying the patch in bug 190195 to a checked out r242826 head tree, then compare the expected diff to the resulting diff. I believe this is due to the last line of the patch attached to bug 190195 = not ending with a linefeed. Expected: [...] > "Northbridge Proximity Temperature", \ > "Wireless Module Temperature", } > #define ASMC_MP_TEMPS { "TA0P", "TCAG", "TCAH", "TCBG", "TCBH", \ Seen: [...]=20 > "Northbridge Proximity Temperature", \ > "Wireless Module Temperature", } > "Wireless Module Temperature", } #define ASMC_MP_TEMPS { "TA0P", "TCAG", "TCAH", "TCBG", "TCBH", \ --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191641-8>