Date: Wed, 10 Feb 2021 11:46:11 -0400 From: Joseph Mingrone <jrm@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r564803 - in head/sysutils: . rmlint rmlint/files Message-ID: <868s7wlyd8.fsf@phe.ftfl.ca> In-Reply-To: <20210210023501.GA65146@FreeBSD.org> (Alexey Dokuchaev's message of "Wed, 10 Feb 2021 02:35:01 %2B0000") References: <202102091926.119JQQL8050604@repo.freebsd.org> <20210210023501.GA65146@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain On Wed, 2021-02-10 at 02:35, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Feb 09, 2021 at 07:26:26PM +0000, Joseph Mingrone wrote: >> New Revision: 564803 >> URL: https://svnweb.freebsd.org/changeset/ports/564803 >> Log: >> New port, sysutils/rmlint: Remove duplicates from your filesystem > Hi Joseph, > I'm afraid this was not sufficiently reviewed, there are number of > issues with this port, I'll comment on the more serious ones. All should be fixed in r564864. There was a long gap between when I first looked at this submission and when I committed. I thought that I had reviewed it more closely, but apparently not. When it passed build and run tests, I committed too quickly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmAj/8NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnqpRD/4lPsql3q8lBN7Fi4fn7JBwwMTTkhHtX5Uk /WBf6ogpF5+HXIi3uvKcJK1Ja1gHMKLmP7bYm14Pk/7RLqSSl92fWwdML1dJOXQA kp8FQLuFm87yzmtjlV8li3tmK+B4i1TiEkpYnc7IHIFlqWsPSB0GLeUeLISvZE1k 9f+U3D+FbRmcBaTSuiL95hQT6268GRuUdgCwqZhw01DzVqHaWbv1v8tzlJDOhOTR 21RnbMh0qji8zEmFh6HHnUCqop+9Uq2/0TI7LXLbya0pg5P8RsFXZIO8KJt8uAgn 8KRSOIZEU+EIx601UFZEdPjdLkRs+0DBgaqgm9wB/+XJ56JhMAJ89xzf8Xjclj7U CvTA8ElqkfDeqIOJRYUU2wmFOgZNrQUhjFWNvQV/MPQKXhfbkmD2SfhFjitXDZi/ dTrp28L0LuBzVRf5naXrGMZL6t8a6NPMXvW/mIXgcmQBkXVOoUFuSa7HnXVvE0zS MKacvpoMj72tFowvhzSsribcsjTXrYFVqdsufOt+Uo1wukYHflXOTEMRk/byQA6p nBOPEiEcKXyjpn0IXZtFEnRalissLO3YNtphjOVqTDkXsCaAlUL23MgFeWM01P4Q LbIsjcLiYq/dhi8JPETlgJTjJ1UQgWCHGw7TgiE4bm2bIDCYd2AB80TMLwDdmrDI L4boIDf6YA== =zjU+ -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?868s7wlyd8.fsf>