Date: Mon, 26 Jul 2021 16:13:12 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 4e16399f4507 - stable/13 - ipoib: Destroying a CQ should never fail. Message-ID: <202107261613.16QGDCuc005130@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=4e16399f450767642a875ef6660169e9fc6113d1 commit 4e16399f450767642a875ef6660169e9fc6113d1 Author: Hans Petter Selasky <hselasky@FreeBSD.org> AuthorDate: 2021-06-16 13:01:32 +0000 Commit: Hans Petter Selasky <hselasky@FreeBSD.org> CommitDate: 2021-07-26 16:04:28 +0000 ipoib: Destroying a CQ should never fail. Remove not needed error handling when destroying a CQ. The function in question will later on be updated to return "void". Reviewed by: kib Sponsored by: Mellanox Technologies // NVIDIA Networking (cherry picked from commit eafc89853835147bcbd019a974ebfa9d3a8b00a7) --- sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c b/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c index c459b3fb55a7..35fd7875b77d 100644 --- a/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c +++ b/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c @@ -254,11 +254,9 @@ void ipoib_transport_dev_cleanup(struct ipoib_dev_priv *priv) clear_bit(IPOIB_PKEY_ASSIGNED, &priv->flags); } - if (ib_destroy_cq(priv->send_cq)) - ipoib_warn(priv, "ib_cq_destroy (send) failed\n"); + ib_destroy_cq(priv->send_cq); - if (ib_destroy_cq(priv->recv_cq)) - ipoib_warn(priv, "ib_cq_destroy (recv) failed\n"); + ib_destroy_cq(priv->recv_cq); ipoib_cm_dev_cleanup(priv);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107261613.16QGDCuc005130>