Date: Mon, 2 Jun 1997 20:40:05 -0700 (PDT) From: denny1@home.com To: freebsd-gnats-submit@FreeBSD.ORG Subject: bin/3766: ping has a few missing ntohs() & ntohl() Message-ID: <199706030340.UAA01161@hub.freebsd.org> Resent-Message-ID: <199706030350.UAA01400@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 3766
>Category: bin
>Synopsis: ping has a few missing ntohs() & ntohl()
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jun 2 20:50:00 PDT 1997
>Last-Modified:
>Originator: Denton Gentry
>Organization:
>Release: FreeBSD-current as of 6/2/97
>Environment:
no FreeBSD machine
>Description:
ping.c is missing a few ntohs/ntohl wrappers around fields in the
more obscure icmp codes.
>How-To-Repeat:
Found by source inspection while working on ping for OpenBSD.
>Fix:
943c943
< ntohs(icp->icmp_nextmtu));
---
> icp->icmp_nextmtu);
989c989
< (void)printf("(New addr: 0x%08lx)\n", ntohl(icp->icmp_gwaddr.s_addr));
---
> (void)printf("(New addr: 0x%08lx)\n", icp->icmp_gwaddr.s_addr);
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199706030340.UAA01161>