Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 10 Jan 2019 11:22:03 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 234817] databases/pgpool-II-40: Broken PAM option?
Message-ID:  <bug-234817-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234817

            Bug ID: 234817
           Summary: databases/pgpool-II-40: Broken PAM option?
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: tz@freebsd.org
          Reporter: tobik@freebsd.org
                CC: tz@freebsd.org
          Assignee: tz@freebsd.org
             Flags: maintainer-feedback?(tz@freebsd.org)
 Attachment #200981 maintainer-approval?(tz@freebsd.org)
             Flags:
                CC: tz@freebsd.org

Created attachment 200981
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200981&action=
=3Dedit
pgpool-II-40.diff

This has been raised on ports-committers before for ports r485048,
but was ignored so far.  I am filing this bug so that this is not
lost.  Since I have cleaned up some ports where variables are set
twice, introducing all sort of problems, over the last couple of days,
this has come up again.

pgpool-II-40 does the following with the PAM and SSL options:

SSL_CONFIGURE_WITH=3D     openssl=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20
SSL_USES=3D               ssl=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20

.include <bsd.port.options.mk>=20=20

.if ${PORT_OPTIONS:MPAM}=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20
#CONFIGURE_ARGS+=3D       --with-pam=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20
SSL_CONFIGURE_WITH=3D     pam=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20
.endif=20=20=20=20=20

Here SSL_CONFIGURE_WITH is set twice and seems to be tangled up
with the PAM option in a way that does not make much immediate
sense.

For starters, it does not make sense to set an options helper after
including bsd.port.options.mk.  It is an artifact of how make(1)
process variables, and how SSL_CONFIGURE_WITH was defined before
including bsd.port.options.mk as well, that this actually does
something here, i.e. add --with-pam to CONFIGURE_ARGS.

The PAM option currently does nothing without the SSL option turned
on.  If this entanglement is correct (I do not think it is) then at
the very least a PAM_IMPLIES=3DSSL is missing.

I'm attaching a patch that hopefully cleans this up.

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234817-7788>