Date: Sat, 26 Sep 2015 13:22:54 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r288270 - head/usr.bin Message-ID: <73F521FD-0959-4DC0-9F3B-F0EA19DDD578@FreeBSD.org> In-Reply-To: <201509261428.t8QES5KU004359@repo.freebsd.org> References: <201509261428.t8QES5KU004359@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Please revert this. I am away for the day. Regards, Bryan Drewery > On Sep 26, 2015, at 07:28, Bryan Drewery <bdrewery@FreeBSD.org> wrote: > > Author: bdrewery > Date: Sat Sep 26 14:28:04 2015 > New Revision: 288270 > URL: https://svnweb.freebsd.org/changeset/base/288270 > > Log: > Hookup mkcsmapper_static and mkesdb_static for all but install. > > These are only handled as 'build-tools' in Makefile.inc1. This causes > 'make clean' from the top of the tree to not clean the directories. It also > effectively has kept them disconnected and risks them bitrotting. The > buildworld process never cleans them either. > > Connect them so they will always be built, cleaned, etc, but never installed. > > Discussed with: imp (briefly) > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/usr.bin/Makefile > > Modified: head/usr.bin/Makefile > ============================================================================== > --- head/usr.bin/Makefile Sat Sep 26 14:27:21 2015 (r288269) > +++ head/usr.bin/Makefile Sat Sep 26 14:28:04 2015 (r288270) > @@ -401,6 +401,13 @@ SUBDIR+= who > SUBDIR+= svn > .endif > > +# These are normally only handled for build-tools. Connect them for > +# all but installing to keep them reasonably connected. > +.if !make(install) > +SUBDIR+= mkcsmapper_static > +SUBDIR+= mkesdb_static > +.endif > + > .include <bsd.arch.inc.mk> > > SUBDIR:= ${SUBDIR:O} >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73F521FD-0959-4DC0-9F3B-F0EA19DDD578>