Date: Fri, 24 Mar 2023 07:08:51 GMT From: Kristof Provost <kp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: ad729f8d503e - main - pf: ignore ip6_output() return value in pf_refragment6() Message-ID: <202303240708.32O78pYi023750@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=ad729f8d503e26ddfe4dcc0fa701720c753bd3ba commit ad729f8d503e26ddfe4dcc0fa701720c753bd3ba Author: Kristof Provost <kp@FreeBSD.org> AuthorDate: 2023-03-24 05:39:01 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2023-03-24 07:08:19 +0000 pf: ignore ip6_output() return value in pf_refragment6() We can't do anything if ip6_output() fails, other than discard the packet which ip6_output() already does for us. Mark the return value as ignored. Reported by: emaste, Coverity Sponsored by: Rubicon Communications, LLC (Netgate) --- sys/netpfil/pf/pf_norm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/pf/pf_norm.c b/sys/netpfil/pf/pf_norm.c index 8d36e72d71b2..2eb1bd69294c 100644 --- a/sys/netpfil/pf/pf_norm.c +++ b/sys/netpfil/pf/pf_norm.c @@ -1020,7 +1020,8 @@ pf_refragment6(struct ifnet *ifp, struct mbuf **m0, struct m_tag *mtag, MPASS(m->m_pkthdr.rcvif != NULL); ip6_forward(m, 0); } else { - ip6_output(m, NULL, NULL, 0, NULL, NULL, NULL); + (void)ip6_output(m, NULL, NULL, 0, NULL, NULL, + NULL); } else m_freem(m);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303240708.32O78pYi023750>