Date: Mon, 12 Feb 2001 17:41:38 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Alexey Zelkin <phantom@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale lmessages.c lmonetary.c lnumeric.c Message-ID: <20010212174137.A7981@nagual.pp.ru> In-Reply-To: <200102120856.f1C8ueE34452@freefall.freebsd.org>; from phantom@FreeBSD.org on Mon, Feb 12, 2001 at 12:56:40AM -0800 References: <200102120856.f1C8ueE34452@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 12, 2001 at 00:56:40 -0800, Alexey Zelkin wrote:
> phantom 2001/02/12 00:56:40 PST
>
> Modified files:
> lib/libc/locale lmessages.c lmonetary.c lnumeric.c
> Log:
> Make comparsions more clear (per style(9))
lmessages.c: as I already write
if (ret == 0) {
should be
if (ret == 0 && _messages_using_locale) {
(and second time too).
BTW it is strange to load shorter locale once again (i.e. repeat stdio
read) while it is already in the buffer. The code should be rewritted in
the manner as old timelocal.c did, i.e. return back line count. Using this
line count, upper level code must decide which form of locale (short,
long, broken) is loaded.
--
Andrey A. Chernov
http://ache.pp.ru/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010212174137.A7981>