Date: Sat, 05 Jul 2008 09:12:46 +0200 From: Gabor PALI <pgj@FreeBSD.org> To: Giorgos Keramidas <keramida@freebsd.org> Cc: doc-committers@freebsd.org, cvs-doc@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/faq book.sgml Message-ID: <486F1EEE.3050202@FreeBSD.org> In-Reply-To: <878wwhvvor.fsf@kobe.laptop> References: <200807050224.m652OWW9021964@repoman.freebsd.org> <878wwhvvor.fsf@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Giorgos,
> If there is an already built version of the ppp(8) binary, this will
> simply install the already existing binary, and then proceed to
> delete it.
Hm... You are right! Thank you for calling my attention to this.
Whether `make clean install clean` is able to reach the same goal? :)
> The suggestion about STRIP= and CFLAGS+='-g' is a bit old now too.
I had the same suspicion (especially for STRIP), but it seems it managed
to escape our (my, gabor's and the reviewers') observation somehow.
> cd /usr/src/usr.sbin/ppp env DEBUG_FLAGS='-g' make clean env
> DEBUG_FLAGS='-g' make install
However, I think CFLAGS still can be used for inclusion of debug
symbols, although your env(1) based solution is a good (and very
elegant!) idea for ones who do not want to modify their /etc/make.conf
every time.
> Does the following patch for this question look ok to you?
Your version is very nice, I would be happy to add it to the FAQ. I
would like to ask doc committers (and FAQ patchletter reviewers) reading
this mail to review and comment on Giorgos' patch to have a third-party
review.
Giorgos, would you approve my commit for this patch in advance? Sorry
for that, but I am actually a guest here :)
> Just replying to a ${random} FAQ commit...
>
> Thank you!
You are welcome. But it is coming also to my tireless reviewer, Tom
Rhodes, and my former mentor to the Hungarian tree, Gabor Kovesdan, who
spent their expensive time on reading, correcting, improving and
approving my patches continuously.
:g
PS: Hey, Giorgios, what about my checkupdate patches? Have you tried or
reviewed them? I already started to use them as you will see very soon :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?486F1EEE.3050202>