Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 20 Jul 2020 23:47:28 +0000 (UTC)
From:      Richard Scheffenegger <rscheff@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r363380 - head/sys/netinet/cc
Message-ID:  <202007202347.06KNlSpO063398@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rscheff
Date: Mon Jul 20 23:47:27 2020
New Revision: 363380
URL: https://svnweb.freebsd.org/changeset/base/363380

Log:
  Add MODULE_VERSION to TCP loadable congestion control modules.
  
  Without versioning information, using preexisting loader /
  linker code is not easily possible when another module may
  have dependencies on pre-loaded modules, and also doesn't
  allow the automatic loading of dependent modules.
  
  No functional change of the actual modules.
  
  Reviewed by:	tuexen (mentor), rgrimes (mentor)
  Approved by:	tuexen (mentor), rgrimes (mentor)
  MFC after:	2 weeks
  Sponsored by:	NetApp, Inc.
  Differential Revision:	https://reviews.freebsd.org/D25744

Modified:
  head/sys/netinet/cc/cc_cdg.c
  head/sys/netinet/cc/cc_chd.c
  head/sys/netinet/cc/cc_cubic.c
  head/sys/netinet/cc/cc_dctcp.c
  head/sys/netinet/cc/cc_hd.c
  head/sys/netinet/cc/cc_htcp.c
  head/sys/netinet/cc/cc_newreno.c
  head/sys/netinet/cc/cc_vegas.c

Modified: head/sys/netinet/cc/cc_cdg.c
==============================================================================
--- head/sys/netinet/cc/cc_cdg.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_cdg.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -714,5 +714,5 @@ SYSCTL_UINT(_net_inet_tcp_cc_cdg, OID_AUTO, loss_compe
     "the window backoff for loss based CC compatibility");
 
 DECLARE_CC_MODULE(cdg, &cdg_cc_algo);
-
+MODULE_VERSION(cdg, 1);
 MODULE_DEPEND(cdg, ertt, 1, 1, 1);

Modified: head/sys/netinet/cc/cc_chd.c
==============================================================================
--- head/sys/netinet/cc/cc_chd.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_chd.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -493,4 +493,5 @@ SYSCTL_UINT(_net_inet_tcp_cc_chd,  OID_AUTO, use_max,
     "as the basic delay measurement for the algorithm.");
 
 DECLARE_CC_MODULE(chd, &chd_cc_algo);
+MODULE_VERSION(chd, 1);
 MODULE_DEPEND(chd, ertt, 1, 1, 1);

Modified: head/sys/netinet/cc/cc_cubic.c
==============================================================================
--- head/sys/netinet/cc/cc_cubic.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_cubic.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -473,3 +473,4 @@ cubic_ssthresh_update(struct cc_var *ccv)
 
 
 DECLARE_CC_MODULE(cubic, &cubic_cc_algo);
+MODULE_VERSION(cubic, 1);

Modified: head/sys/netinet/cc/cc_dctcp.c
==============================================================================
--- head/sys/netinet/cc/cc_dctcp.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_dctcp.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -464,3 +464,4 @@ SYSCTL_PROC(_net_inet_tcp_cc_dctcp, OID_AUTO, slowstar
     "half CWND reduction after the first slow start");
 
 DECLARE_CC_MODULE(dctcp, &dctcp_cc_algo);
+MODULE_VERSION(dctcp, 1);

Modified: head/sys/netinet/cc/cc_hd.c
==============================================================================
--- head/sys/netinet/cc/cc_hd.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_hd.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -251,4 +251,5 @@ SYSCTL_PROC(_net_inet_tcp_cc_hd, OID_AUTO, queue_min,
     "minimum queueing delay threshold (qmin) in ticks");
 
 DECLARE_CC_MODULE(hd, &hd_cc_algo);
+MODULE_VERSION(hd, 1);
 MODULE_DEPEND(hd, ertt, 1, 1, 1);

Modified: head/sys/netinet/cc/cc_htcp.c
==============================================================================
--- head/sys/netinet/cc/cc_htcp.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_htcp.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -530,3 +530,4 @@ SYSCTL_UINT(_net_inet_tcp_cc_htcp, OID_AUTO, rtt_scali
     "enable H-TCP RTT scaling");
 
 DECLARE_CC_MODULE(htcp, &htcp_cc_algo);
+MODULE_VERSION(htcp, 1);

Modified: head/sys/netinet/cc/cc_newreno.c
==============================================================================
--- head/sys/netinet/cc/cc_newreno.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_newreno.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -396,3 +396,4 @@ SYSCTL_PROC(_net_inet_tcp_cc_newreno, OID_AUTO, beta_e
     "New Reno beta ecn, specified as number between 1 and 100");
 
 DECLARE_CC_MODULE(newreno, &newreno_cc_algo);
+MODULE_VERSION(newreno, 1);

Modified: head/sys/netinet/cc/cc_vegas.c
==============================================================================
--- head/sys/netinet/cc/cc_vegas.c	Mon Jul 20 22:32:39 2020	(r363379)
+++ head/sys/netinet/cc/cc_vegas.c	Mon Jul 20 23:47:27 2020	(r363380)
@@ -301,4 +301,5 @@ SYSCTL_PROC(_net_inet_tcp_cc_vegas, OID_AUTO, beta,
     "vegas beta, specified as number of \"buffers\" (0 < alpha < beta)");
 
 DECLARE_CC_MODULE(vegas, &vegas_cc_algo);
+MODULE_VERSION(vegas, 1);
 MODULE_DEPEND(vegas, ertt, 1, 1, 1);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202007202347.06KNlSpO063398>