Date: Tue, 16 Nov 1999 10:58:06 +0200 From: Sheldon Hearn <sheldonh@uunet.co.za> To: Pierre Beyssac <beyssac@enst.fr> Cc: Bruce Evans <bde@zeta.org.au>, Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, freebsd-current@FreeBSD.ORG Subject: Re: egcs -O breaks ping.c:in_cksum() Message-ID: <44963.942742686@axl.noc.iafrica.com> In-Reply-To: Your message of "Tue, 16 Nov 1999 09:45:36 %2B0100." <19991116094536.A44999@enst.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 16 Nov 1999 09:45:36 +0100, Pierre Beyssac wrote:
> > - volatile u_short answer = 0;
> > + union {
> > + u_int16_t us;
> > + u_int8_t uc[2];
> > + } answer;
> Uh, which one(s) do you mean exactly? The 4-space indented union
> (I just followed style(9))
The word ``union'' doesn't appear in style(9) and a 1 tab indent is used
consistently in the examples of structs. Use 1 tab.
> or the double space before uc[2] (it was just to align us and uc
> vertically)?
Use tabs for that as well.
Look at the rest of ping.c, and you'll see that 4-space indents aren't
used except to prevent line-wrap in one weird case of a switch block and
for run-over lines.
Ciao,
Sheldon.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44963.942742686>