Date: Sat, 23 Feb 2002 13:23:35 +0100 (CET) From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/35239: wwww/linux-netscape6 doesn't respect WRKDIRPREFIX, IS_INTERACTIVE Message-ID: <200202231223.g1NCNZb90375@elevation.zuhause.stoert.net>
next in thread | raw e-mail | index | archive | help
>Number: 35239
>Category: ports
>Synopsis: wwww/linux-netscape6 doesn't respect WRKDIRPREFIX, IS_INTERACTIVE
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Feb 23 04:30:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Simon 'corecode' Schubert
>Release: FreeBSD 4.5-STABLE i386
>Organization:
>Environment:
System: FreeBSD elevation.zuhause.stoert.net 4.5-STABLE FreeBSD 4.5-STABLE #6: Sat Feb 9 22:49:14 CET 2002 corecode@elevation.zuhause.stoert.net:/usr/obj/i386/k7/usr/src/sys/ELEVATION i386
ports cvsupped every day 02:00 CET (-0100)
>Description:
linux-netscape6 doesn't respect WRKDIRPREFIX when assigning DISTFILES
furthermore error output isn't 2>/dev/null
this results is garbage being used when portsdb(1) updates the db.
the supplied scripts/configure checks for BATCH but the port itself
doesn't set IS_INTERACTIVE. this breaks building the port unattended.
>How-To-Repeat:
cd /usr/ports/wwww/linux-netscape6
make -V DISTFILES -V IS_INTERACTIVE
>Fix:
consider something like this:
--- Makefile.orig Sat Feb 23 13:15:41 2002
+++ Makefile Sat Feb 23 13:21:20 2002
@@ -69,13 +69,20 @@
PLIST= ${WRKDIR}/pkg-plist
STARTUP_CMD= netscape6
+.if !defined(BATCH)
+IS_INTERACTIVE= yes
+.endif
+
.include <bsd.port.pre.mk>
+.if exists(${WRKSRC}/components.conf)
+DISTFILES!= ${CAT} ${WRKSRC}/components.conf 2>/dev/null
+.endif
+
pre-everything::
${MKDIR} ${WRKSRC}/bin/plugins ${WRKSRC}/bin/chrome \
${WRKSRC}/plugins
${SETENV} ${SCRIPTS_ENV} ${SH} ${SCRIPTDIR}/configure
-DISTFILES!=${CAT} ${.CURDIR}/work/${WRKSRC}/components.conf; ${TRUE}
do-extract:
.for i in ${DISTFILES}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202231223.g1NCNZb90375>