Date: Sat, 07 Jul 2018 08:53:53 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: daichi@FreeBSD.org, eadler@FreeBSD.org, gnn@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336028 - head/usr.bin/top Message-ID: <20180707.085353.1746062843251989845.hrs@allbsd.org> In-Reply-To: <201807061207.w66C76CR043533@repo.freebsd.org> References: <201807061207.w66C76CR043533@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Sat_Jul__7_08_53_53_2018_274)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Daichi GOTO <daichi@FreeBSD.org> wrote in <201807061207.w66C76CR043533@repo.freebsd.org>: da> Author: daichi da> Date: Fri Jul 6 12:07:06 2018 da> New Revision: 336028 da> URL: https://svnweb.freebsd.org/changeset/base/336028 da> da> Log: da> Changed to eliminate the upper limit of command length displayed da> by "-a" and expand to match terminal width da> da> Reviewed by: eadler da> Approved by: gnn (mentor) da> Differential Revision: https://reviews.freebsd.org/D16083 da> da> Modified: da> head/usr.bin/top/display.c da> head/usr.bin/top/machine.c da> head/usr.bin/top/screen.c da> head/usr.bin/top/top.h This change breaks displaying a prompt and messages in the interactive mode by new_message() when typing "o" or "p", for example. While r336031 fixed a warning in GCC, it does not fix the problem itself. Please fix it. I also think restructure of the buffer management is required first if we want to eliminate the column width limitation. Using sbuf(9) consistently may be better than incomplete conversion from static arrays to malloc(). -- Hiroki ----Security_Multipart(Sat_Jul__7_08_53_53_2018_274)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iEYEABECAAYFAltAAREACgkQTyzT2CeTzy0qZQCfRAi7K7p18TxqQkVB1+ELS+8S H4oAn0oJHlMHnedPFfEuUgHMl05hctHR =TOAO -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Jul__7_08_53_53_2018_274)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180707.085353.1746062843251989845.hrs>