Date: Sun, 28 Jul 2013 14:56:30 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r253744 - head/usr.sbin/watchdogd Message-ID: <20130728185630.GJ2272@glenbarber.us> In-Reply-To: <1375037206.45247.17.camel@revolution.hippie.lan> References: <201307281656.r6SGuVYx023459@svn.freebsd.org> <20130728184204.GI2272@glenbarber.us> <1375037206.45247.17.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
--2gg7fA5kVn3CgPY0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 28, 2013 at 12:46:46PM -0600, Ian Lepore wrote: > On Sun, 2013-07-28 at 14:42 -0400, Glen Barber wrote: > > On Sun, Jul 28, 2013 at 04:56:31PM +0000, Ian Lepore wrote: > > > Author: ian > > > Date: Sun Jul 28 16:56:31 2013 > > > New Revision: 253744 > > > URL: http://svnweb.freebsd.org/changeset/base/253744 > > >=20 > > > Log: > > > Fix printf of seconds for systems where time_t is 64 bits. > > >=20 > > > Modified: > > > head/usr.sbin/watchdogd/watchdogd.c > > >=20 > > > Modified: head/usr.sbin/watchdogd/watchdogd.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/usr.sbin/watchdogd/watchdogd.c Sun Jul 28 16:50:45 2013 (r25= 3743) > > > +++ head/usr.sbin/watchdogd/watchdogd.c Sun Jul 28 16:56:31 2013 (r25= 3744) > > > @@ -50,6 +50,7 @@ __FBSDID("$FreeBSD$"); > > > #include <paths.h> > > > #include <signal.h> > > > #include <stdio.h> > > > +#include <stdint.h> > > > #include <stdlib.h> > > > #include <string.h> > > > #include <strings.h> > > > @@ -230,10 +231,10 @@ parse_timeout_to_pow2ns(char opt, const=20 > > > if (debugging) { > > > printf("Timeout for %s%s " > > > "is 2^%d nanoseconds " > > > - "(in: %s sec -> out: %ld sec %ld ns -> %d ticks)\n", > > > + "(in: %s sec -> out: %jd sec %ld ns -> %d ticks)\n", > > > longopt ? "-" : "", longopt ? longopt : shortopt, > > > rv, > > > - myoptarg, ts.tv_sec, ts.tv_nsec, ticks); > > > + myoptarg, (intmax_t)ts.tv_sec, ts.tv_nsec, ticks); > >=20 > > This breaks head/ for at least arm. > >=20 > > cc -O -pipe -std=3Dgnu99 -Qunused-arguments -Wsystem-headers -Werror > > -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign > > -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare > > -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function > > -Wno-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-paramete= r -o watch watch.o -ltermcap > > gzip -cn /src/usr.sbin/watch/watch.8 > watch.8.gz > > =3D=3D=3D> usr.sbin/watchdogd (all) > > cc -O -pipe -std=3Dgnu99 -Qunused-arguments -Wsystem-headers -Werror > > -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > > -Wold-style-definition -Wmissing-variable-declarations -Wno-pointer-sign > > -Wno-empty-body -Wno-string-plus-int -c > > /src/usr.sbin/watchdogd/watchdogd.c > > /src/usr.sbin/watchdogd/watchdogd.c:236:17: error: format specifies type > > 'long' but the argument has type 'time_t' (aka 'long long') > > [-Werror,-Wformat] > > myoptarg, ts.tv_sec, ts.tv_nsec, ticks); > > ^~~~~~~~~ > > 1 error generated. > > *** Error code 1 > >=20 > > Stop. > > bmake: stopped in /src/usr.sbin/watchdogd > > *** Error code 1 > >=20 > > http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-armv6-arm.full > >=20 > > Glen > >=20 >=20 > Umm, no, it fixes the error you cite (tinderbox hasn't caught up to the > fix yet). >=20 Ugh. My eyes do not seem to work then... Sorry for the noise. Glen --2gg7fA5kVn3CgPY0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJR9WleAAoJEFJPDDeguUaj12EH/jfAFupJrteFL3/39Eqt+Hx3 Bbk6Grr5JU5HmxFMgbUr5LZF+Lnsxicn0vHyTyKClzPAXMnwaP1hlzOgpfhoG9c8 WvPyIPF+dpURX69GM77z7CSXLvYN23ohCwN1Q0IDqdczB35BqZacAi2SkWhj6ktM /Fw9ckQAb5f5r3alSGQggpd4WRIllZRYwOSc7CtIq0jyyVfMB3UMonz798qsLsWj Mlt7Fh10VN5IUkSHty/lc48Eli28lMzs89mNdx7PVdCUMrhHnyZIIzVv8PdXQOdX Ea0JKNaJXVFUde4UMgUM5coE6KOAblZlj6Ht0tAhFC1xGhhlygDN7kcAYr1TjmQ= =LBHD -----END PGP SIGNATURE----- --2gg7fA5kVn3CgPY0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130728185630.GJ2272>