Date: Mon, 16 Jul 2012 16:00:49 +0400 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-hackers <freebsd-hackers@FreeBSD.org>, Marius Strobl <marius@FreeBSD.org>, freebsd-current <freebsd-current@FreeBSD.org>, Pawel Jakub Dawidek <pjd@FreeBSD.org> Subject: Re: [CFC/CFT] large changes in the loader(8) code Message-ID: <50040271.5000301@FreeBSD.org> In-Reply-To: <5003FB9D.90909@FreeBSD.org> References: <4FE9B01C.30306@yandex.ru> <5003EBAB.6030507@FreeBSD.org> <5003F39D.6030808@FreeBSD.org> <5003F589.40603@FreeBSD.org> <5003F79E.1060706@FreeBSD.org> <5003FB9D.90909@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig09929B86E2E15E68F7B5E8F9 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 16.07.2012 15:31, Andriy Gapon wrote: >> Yes. It should work as before. >=20 > Well, but it's obvious that zfs_probe_dev would be attempting to do som= e unneeded > stuff (trying to treat partitions as disks) for that case. To me this = is a clear > indication zfs_probe_dev is not optimal for arch-independent implementa= tion. So I > still think that arch_zfs_probe should decide what disks and partitions= to probe, > and zfs_probe_dev should only probe what it's given and not try to be a= ny smarter. > But I've repeated myself three times already :-) And we will have the same - several copies of the same code in each archi= tecture, which i have deleted... Sparc doesn't support DIOCGMEDIASIZE and DIOCGSECTORSIZE ioctls, so it will not check each partition, only fd that is passed to the zfs_pr= obe_dev. Currently there is only one problem with ZFS tasting, that can affect use= rs - now we taste each disk and partition, but in the my branch ZFS tastes onl= y disks and partitions with type "freebsd" and "freebsd-zfs". So if you have created = ZFS on top of MBR partition with type "ntfs", then loader will be unable to detect i= t. --=20 WBR, Andrey V. Elsukov --------------enig09929B86E2E15E68F7B5E8F9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJQBAJ1AAoJEAHF6gQQyKF6oxQH/1StRDHfuQD3PzWQZUcraIni meEi0RN+XneeWY6dJi0A4182cW9uP+sDXkClAYViUEBBjkYgq7bEpZ0sGbengiz/ U+jLooGgYS0K1KalIXkP4nke87OqVKeCr1cwat4fyUg0g1QOTHs9LF77HkQq3AgS Blzz4CHR7/J+nyhp6HIRF19zoIhiZKDMcfOEPjDsC4OrWynnsNR6GMJ1gFxpl/WH RVfMYW9/sux4ggB53HN9pm6+abOOtHFat34FX7nruooBLZJd+JdC8oEUlrWIPgIf 43j7irsAraj/+iQ75KrzKPSUr9i69Mk+mOylA3q7DThZKUjGDAVm70ojSsDl41w= =X6bX -----END PGP SIGNATURE----- --------------enig09929B86E2E15E68F7B5E8F9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50040271.5000301>