Date: Tue, 8 Aug 2006 12:39:54 GMT From: Stefan Sperling <freebsd-gnats@stsp.in-berlin.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/101653: multimedia/mplayer depends on imake if WITHOUT_X11 is set Message-ID: <200608081239.k78CdsOg037780@www.freebsd.org> Resent-Message-ID: <200608081250.k78CoGnR076263@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 101653
>Category: ports
>Synopsis: multimedia/mplayer depends on imake if WITHOUT_X11 is set
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Aug 08 12:50:15 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Stefan Sperling
>Release: FreeBSD 6.1-RELEASE-p3
>Organization:
>Environment:
FreeBSD gurke.stsp.lan 6.1-RELEASE-p3 FreeBSD 6.1-RELEASE-p3 #3: Mon Aug 7 08:28:26 CEST 2006 stsp@gurke.stsp.lan:/usr/obj/usr/src/sys/GURKE i386
>Description:
First of all, a big thank you to whoever finally cleaned up the
configuration options mess and made the mplayer port heed make config :)
I guess there was a small oversight though. If WITHOUT_X11 is set,
mplayer has a build dependency on imake. This doesn't really make sense.
>How-To-Repeat:
Set WITHOUT_X11=yes in /etc/make.conf.
Install mplayer and note that it wants to install imake as a dependency.
>Fix:
Proposed patch, which assumes that someone made a logic error
and that imake is actually needed if building with X11:
--- Makefile.orig Tue Aug 8 14:00:01 2006
+++ Makefile Tue Aug 8 14:00:08 2006
@@ -216,10 +216,10 @@
.if defined(WITHOUT_X11)
WITHOUT_GUI= yes
-BUILD_DEPENDS+= imake:${X_IMAKE_PORT}
CONFIGURE_ARGS+=--disable-x11
.else
USE_XLIB= yes
+BUILD_DEPENDS+= imake:${X_IMAKE_PORT}
CONFIGURE_ARGS+=--with-x11libdir=${X11BASE}/lib \
--with-x11incdir=${X11BASE}/include
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608081239.k78CdsOg037780>