Date: Fri, 10 Jul 2015 22:01:01 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Matthew D. Fuller" <fullermd@over-yonder.net> Cc: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150710200055.GB1270@garage.freebsd.pl> In-Reply-To: <20150629013841.GO50491@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--O5XBE6gyVG5Rl6Rj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 28, 2015 at 08:38:41PM -0500, Matthew D. Fuller wrote: > > > Stuffed into bugzilla as > > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198860>; > > [...] > > > After last round, everybody seems happy enough with this, so I've > > > filed it as > > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198863>. > >=20 > > Does anybody have outstanding concerns on these? Or, if not, what > > else do we need to move them along? They're working fine for me > > here... >=20 > Ping... still working fine here, and I'm pretty sure I've addressed > every concern anybody's raised. Matthew, I'm sorry that it took me so long to get to your patch. The good news is that I like the patch - it looks clean and complete. The bad news is that I like it a bit too much:) I think I'd prefer that BIO_DELETE is passed through by default and there is an option to turn it off. This would mean changing -t option to -T for init and onetime and renaming the G_ELI_FLAG_DELETE flag to G_ELI_FLAG_IGNORE_DELETE. OR... just removing the ability to ignore BIO_DELETEs. The latter is appealing especially if some days we will implement BIO_DELETEs as overwrites. Then we should have an option to turn that on, which would turn off TRIM/UNMAP. Thinking about it some more, I believe that if someone doesn't want TRIM/UNMAP to hit his SSDs it should be configurable on per-SSD basis and not on every layer above SSD. So at the end I'd change my preference to just passing BIO_DELETEs always. What do you think? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --O5XBE6gyVG5Rl6Rj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVoCR3AAoJEJVLhSuxKFt13fUP/juY4IFaXVXMFtgDZYVTWzsn TPkPslFj0jpW+qWYE4aH21WyrXuVe2r6tBaE8c4ao1MZ9EtJv3qWjFf1P6nELf7R RHY+8boW3fuTp7e/R1ijaMkScD5tWs5cHSkvrxrdXsh9LtcPEyEO5djxG+29oZ+9 t1/cSNW40quiTZthP0df7ljwRYT8uW/buO9n1EOLU1sPf8rhlqkoKxfV2FshUcbm 8TK3mAfUC3TIPxqcuMJUDAc+Nguo1FwW0qYwvIbHIHAg4UDEhlxy3QpYJbY9vhAe iX6+lpSAqUxfgs5NiEAiWeH340a81z/QVM3nG8HVPZaA0DTimmp++Lqa9pwv8p1U xFsKd3R/YdYmBbbepCyYS0G2qKmTUysvtns6RVDwLzZWXoctSdjXvAYoXDi9WG3G wVwSUWQGRad2j0QhffzWAC/ViXrsfFd3e3JyI1qWIq8XWMcXtPJeew01Ewox0PEQ 5mUvQYIpwdrbk5MB3V5jK/IGlVzMB0VOAcSIWwQYRwvlygjP5G37lyU0xkRc5u5f Abi0baZLUk79Wos8PyGbvMMAgee0H4Vk9PwZKQRbgl5yV+4LooUnYKeDrHecRDU4 baqnJzMMtxKavUCTpIJIXTASR22aqoMSXhX6K3EX/o+yG13qFHezkzMCeSrlUQaz jOd3m8wHgQgdZL7q2CW6 =WZrH -----END PGP SIGNATURE----- --O5XBE6gyVG5Rl6Rj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150710200055.GB1270>