Date: Mon, 23 Feb 2004 09:09:22 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: scottl@FreeBSD.org Cc: jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha mem.c promcons.c src/sys/alpha/tlsb zs_tlsb.c src/sys/amd64/amd64 mem.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_ch.c scsi_pass.c scsi_pt.c s Message-ID: <20040223.090922.112923872.imp@bsdimp.com> In-Reply-To: <403A22BB.6010409@freebsd.org> References: <8758.1077551092@critter.freebsd.dk> <403A22BB.6010409@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <403A22BB.6010409@freebsd.org>
Scott Long <scottl@FreeBSD.org> writes:
: I agree with these arguments. However, I would have liked to have seen
: a small grace period defined, especially since people are now bumping
: into the consequences of this change and not knowing why. I plan to do
: this with the interrupt API change when it comes.
Especially since the code to do this is on the order of:
if (devsw->d_version == 0) {
printf("Warning, older interface ...");
devsw->d_flags ^= D_NEEDGIANT;
devsw->d_version = D_VERSION_00;
}
unless there are other issues not elucidated (I'm only looking at the
new code). One could also have had two different bits so APIly it
changed, but you could whine if only one of them was set.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040223.090922.112923872.imp>