Date: Thu, 16 Feb 2012 19:56:09 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, eadler@FreeBSD.org Subject: Re: svn commit: r231817 - head/usr.sbin/IPXrouted Message-ID: <20120216194921.X1656@besplex.bde.org> In-Reply-To: <20120216.164332.2209961872967607025.hrs@allbsd.org> References: <201202160517.q1G5H6Z0000155@svn.freebsd.org> <20120216.164332.2209961872967607025.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 16 Feb 2012, Hiroki Sato wrote: > Eitan Adler <eadler@FreeBSD.org> wrote > in <201202160517.q1G5H6Z0000155@svn.freebsd.org>: > > ea> Author: eadler > ea> Date: Thu Feb 16 05:17:06 2012 > ea> New Revision: 231817 > ea> URL: http://svn.freebsd.org/changeset/base/231817 > ea> > ea> Log: > ea> Fix warning when compiling with gcc46 > IMHO it is not a good idea to remove unused code partially like this > or unused code in one from another project if you just want to > suppress a compiler warning. It may suppress the warning, but > remaining bits in comments and/or conditional parts where the > compiler does not complain make developers confused. I think it is > more harmful than the warning. This is another example of the phenomenon that small bikesheds are the hardest to paint :-). It is surprisingly difficult to make many small harmless-looking changes correctly without knowing their full context, since just determining their full context may take a day or three. Each. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120216194921.X1656>