Date: Mon, 8 Jun 2015 10:32:10 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r284116 - head/sys/boot/ficl Message-ID: <CAOfEmZgifDBgLxP9DuBFA9UhAQHOM59b3y3BW=S07x2SxY8ykA@mail.gmail.com> In-Reply-To: <5574A2F9.8080404@FreeBSD.org> References: <201506071420.t57EKnio083109@svn.freebsd.org> <5F622B98-A1AE-41FB-8E4A-E767DB928689@gmail.com> <5574A2F9.8080404@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2015-06-08 4:00 GMT+08:00 Pedro Giffuni <pfg@freebsd.org>: > > > On 06/07/15 12:06, Garrett Cooper wrote: > >> On Jun 7, 2015, at 07:20, Marcelo Araujo <araujo@FreeBSD.org> wrote: >>> >>> Author: araujo (ports committer) >>> Date: Sun Jun 7 14:20:48 2015 >>> New Revision: 284116 >>> URL: https://svnweb.freebsd.org/changeset/base/284116 >>> >>> Log: >>> Include header libi386.h to silence the clang warning of implicit >>> declaration >>> of functions biospci_*. >>> >>> Differential Revision: D2668 >>> Reviewed by: rodrigc >>> >>> Modified: >>> head/sys/boot/ficl/loader.c >>> >>> Modified: head/sys/boot/ficl/loader.c >>> >>> ============================================================================== >>> --- head/sys/boot/ficl/loader.c Sun Jun 7 13:59:02 2015 (r284115) >>> +++ head/sys/boot/ficl/loader.c Sun Jun 7 14:20:48 2015 (r284116) >>> @@ -46,6 +46,7 @@ >>> #include "bootstrap.h" >>> #include <string.h> >>> #include "ficl.h" >>> +#include "../i386/libi386/libi386.h" >>> >> Hi Marcelo, >> >> This commit's explicitly polluting the ficl interpreter with code from >> x86 on all platforms. Seems like the code should be refactored to not >> explicitly include this symbol, then #include this header there. That's the >> real bug.. >> > +1 > > Let's revert and let the ficl GSoC take care of it. > > Pedro. > Done, thanks! -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZgifDBgLxP9DuBFA9UhAQHOM59b3y3BW=S07x2SxY8ykA>