Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 29 Jun 2016 19:34:30 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 210706] freebsd/sys/boot/efi/boot1/boot1.c:631]: (style) Suspicious condition
Message-ID:  <bug-210706-8@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail 

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210706

            Bug ID: 210706
           Summary: freebsd/sys/boot/efi/boot1/boot1.c:631]: (style)
                    Suspicious condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

freebsd/sys/boot/efi/boot1/boot1.c:631]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

Source code is

        if ((status = bs->AllocatePool(EfiLoaderData, hsize,
            (void **)&handles) != EFI_SUCCESS)) {

Maybe better code

        if ((status = bs->AllocatePool(EfiLoaderData, hsize,
            (void **)&handles)) != EFI_SUCCESS) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210706-8>