Date: Tue, 3 Jan 2006 12:13:00 -0500 From: Jung-uk Kim <jkim@FreeBSD.org> To: Darren Reed <darrenr@hub.freebsd.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bpf_filter.c Message-ID: <200601031213.03328.jkim@FreeBSD.org> In-Reply-To: <20051231145027.GB38051@hub.freebsd.org> References: <200512080005.jB8053R4099474@repoman.freebsd.org> <20051231145027.GB38051@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 31 December 2005 09:50 am, Darren Reed wrote: > On Thu, Dec 08, 2005 at 12:05:03AM +0000, Jung-uk Kim wrote: > > jkim 2005-12-08 00:05:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net bpf_filter.c > > Log: > > Do not accept an empty bpf program. > > You need to make one of two follow up changes here: > > 1) explicitly allow 0-length programs > > 2) fix bpf_filter (see the first check and its comments for "return > -1") > > Personally I'd prefer to see (1) because it allows you > to "set" a BPF program and measure the performance impact > of the BPF code on networking without having to worry > about the cost of executing the BPF program itself. Hmm... You're right. I will fix that. Thanks, Jung-uk Kim > Darren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601031213.03328.jkim>