Date: Fri, 14 Nov 2014 13:34:29 +0100 From: Ilya Bakulin <ilya@bakulin.de> To: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org> Cc: Freebsd hackers list <freebsd-hackers@freebsd.org>, freebsd-pf@freebsd.org, freebsd-net <freebsd-net@freebsd.org>, J David <j.david.lists@gmail.com>, owner-freebsd-net@freebsd.org, ermal.luci@gmail.com Subject: Re: Checksumming outgoing packets in PF vs in ip[6]_output Message-ID: <ADF3F167-EF1E-4252-92A3-FAE4659768D6@bakulin.de> In-Reply-To: <CAPBZQG3GgS72wpTscxcQPA5pNSCimpFwquGC=4UOwY4tVyiQSA@mail.gmail.com> References: <d2f0c43909d9c9bada9a5bda7719cfca@mail.bakulin.de> <CABXB=RRWNX6NnxCbebig-L41W4n9ZSBDrzOWa_k_TVHowhSbYg@mail.gmail.com> <CAPBZQG1%2BVWZDYqwFjufO-hM58kbK_WLnnso_Dgsf=1nDQ%2Bi2Ww@mail.gmail.com> <9734b7d34828a102d9a2f5061c11ae3d@mail.bakulin.de> <CAPBZQG3GgS72wpTscxcQPA5pNSCimpFwquGC=4UOwY4tVyiQSA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ermal, yes, this patch works for both #179392 and #172648. What do you need to merge this into -CURRENT and MFC to stable/9? On 2014-11-14 12:57, Ermal Luçi wrote: > Here is a direct patch. > Give it a try. > > For the reply-to issues there is another patch complementary to this i > will send. > > On Fri, Nov 14, 2014 at 11:34 AM, Ilya Bakulin <ilya@bakulin.de> > wrote: > >> Hi all, >> >> actually with _my_ checksumming patch the rdr-to is broken >> completely :-( >> So I'm waiting for Ermal to send an updated version of his patch >> that may really solve the problem! >> >> On 2014-11-14 09:17, Ermal Luçi wrote: >> Yes confirmed it will solve that issue as well. >> >> On Thu, Nov 13, 2014 at 9:30 PM, J David <j.david.lists@gmail.com> >> wrote: >> >> On Wed, Nov 5, 2014 at 9:28 AM, Ilya Bakulin <ilya@bakulin.de> >> wrote: >>> Of course it was interesting what does the upstream PF do (@ >> OpenBSD). >> Seems >>> they have made the decision to >>> leave the task of recalculating the checksums for outgoing >> packets to >>> ip[6]_output, because currently >>> the code there overwrites the checksum anyway. >>> This seems a correct way to me. pf should not longer do any >> checksum >> updates >>> in inbound and outbound path. >> >> Is there any chance this change would help with bug 179392 as well? >> >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=179392 [1] >> >> Or is that a separate issue? >> >> Thanks! >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net [2] >> To unsubscribe, send any mail to >> "freebsd-net-unsubscribe@freebsd.org" > > -- > > Ermal > > Links: > ------ > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=179392 > [2] http://lists.freebsd.org/mailman/listinfo/freebsd-net -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From owner-freebsd-net@FreeBSD.ORG Fri Nov 14 13:08:35 2014 Return-Path: <owner-freebsd-net@FreeBSD.ORG> Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 91B3B70E; Fri, 14 Nov 2014 13:08:35 +0000 (UTC) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 58C85243; Fri, 14 Nov 2014 13:08:35 +0000 (UTC) Received: by mail-pa0-f47.google.com with SMTP id kx10so17530494pab.34 for <multiple recipients>; Fri, 14 Nov 2014 05:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=k91e6+X4iCJo8otmRKo8iS0pLtFK6YhROZ6Rlf3HI98=; b=nM0e38ZwQkwXNODNyGE6/RbEA0SilHtfzn4RDjwrm7T4Uqe2XWxDBynCucl/WBC29o J7LPVvHuTMl4cFdYy/ds4PFbUnl8DIjmGT/Xv2hyQaTb8XbYQdie0prnXEp05Al4JssP w8YBsptGtr10JQ0QnpJKi2/IcfAuU4JyqVHgjdsOSYChlwOOwSVfaIbb3bDjSPeN+Tjx B5LuHe3bnNW7Wnmmk9Jt6QD9EOxV/YP4ka0OpnRNaE0SLeiVmA3+E9OMxBXE5pQ3SHh1 pRKwNi4EzGZ/fcahqMjgxekyCmmlB5X+RCt2oiFkZ9Qq/DpMpP2I9Sl2XMo4QeWA/xpY SSHg== MIME-Version: 1.0 X-Received: by 10.70.131.199 with SMTP id oo7mr10079581pdb.138.1415970513950; Fri, 14 Nov 2014 05:08:33 -0800 (PST) Sender: ermal.luci@gmail.com Received: by 10.70.73.2 with HTTP; Fri, 14 Nov 2014 05:08:33 -0800 (PST) In-Reply-To: <ADF3F167-EF1E-4252-92A3-FAE4659768D6@bakulin.de> References: <d2f0c43909d9c9bada9a5bda7719cfca@mail.bakulin.de> <CABXB=RRWNX6NnxCbebig-L41W4n9ZSBDrzOWa_k_TVHowhSbYg@mail.gmail.com> <CAPBZQG1+VWZDYqwFjufO-hM58kbK_WLnnso_Dgsf=1nDQ+i2Ww@mail.gmail.com> <9734b7d34828a102d9a2f5061c11ae3d@mail.bakulin.de> <CAPBZQG3GgS72wpTscxcQPA5pNSCimpFwquGC=4UOwY4tVyiQSA@mail.gmail.com> <ADF3F167-EF1E-4252-92A3-FAE4659768D6@bakulin.de> Date: Fri, 14 Nov 2014 14:08:33 +0100 X-Google-Sender-Auth: vE7hR9KrsnB7cD3PU_p5tm3KvRU Message-ID: <CAPBZQG2Nu=tA5GVz2XJqH6fodS4Doiys86G9mSsBzFL7CJmEUA@mail.gmail.com> Subject: Re: Checksumming outgoing packets in PF vs in ip[6]_output From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= <eri@freebsd.org> To: Ilya Bakulin <ilya@bakulin.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Freebsd hackers list <freebsd-hackers@freebsd.org>, freebsd-net <freebsd-net@freebsd.org>, J David <j.david.lists@gmail.com>, owner-freebsd-net@freebsd.org, "freebsd-pf@freebsd.org" <freebsd-pf@freebsd.org> X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>; List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 14 Nov 2014 13:08:35 -0000 Hello Ilya, just approval from some people. I will follow-up. On Fri, Nov 14, 2014 at 1:34 PM, Ilya Bakulin <ilya@bakulin.de> wrote: > Hi Ermal, > yes, this patch works for both #179392 and #172648. > > What do you need to merge this into -CURRENT and MFC to stable/9? > > > On 2014-11-14 12:57, Ermal Lu=C3=A7i wrote: > > Here is a direct patch. > > Give it a try. > > > > For the reply-to issues there is another patch complementary to this i > > will send. > > > > On Fri, Nov 14, 2014 at 11:34 AM, Ilya Bakulin <ilya@bakulin.de> > > wrote: > > > >> Hi all, > >> > >> actually with _my_ checksumming patch the rdr-to is broken > >> completely :-( > >> So I'm waiting for Ermal to send an updated version of his patch > >> that may really solve the problem! > >> > >> On 2014-11-14 09:17, Ermal Lu=C3=A7i wrote: > >> Yes confirmed it will solve that issue as well. > >> > >> On Thu, Nov 13, 2014 at 9:30 PM, J David <j.david.lists@gmail.com> > >> wrote: > >> > >> On Wed, Nov 5, 2014 at 9:28 AM, Ilya Bakulin <ilya@bakulin.de> > >> wrote: > >>> Of course it was interesting what does the upstream PF do (@ > >> OpenBSD). > >> Seems > >>> they have made the decision to > >>> leave the task of recalculating the checksums for outgoing > >> packets to > >>> ip[6]_output, because currently > >>> the code there overwrites the checksum anyway. > >>> This seems a correct way to me. pf should not longer do any > >> checksum > >> updates > >>> in inbound and outbound path. > >> > >> Is there any chance this change would help with bug 179392 as well? > >> > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D179392 [1] > >> > >> Or is that a separate issue? > >> > >> Thanks! > >> _______________________________________________ > >> freebsd-net@freebsd.org mailing list > >> http://lists.freebsd.org/mailman/listinfo/freebsd-net [2] > >> To unsubscribe, send any mail to > >> "freebsd-net-unsubscribe@freebsd.org" > > > > -- > > > > Ermal > > > > Links: > > ------ > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D179392 > > [2] http://lists.freebsd.org/mailman/listinfo/freebsd-net > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity. --=20 Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ADF3F167-EF1E-4252-92A3-FAE4659768D6>