Date: Thu, 8 Feb 2018 07:13:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ganael LAPLANCHE <martymac@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r460940 - in head/games: afternoonstalker burgerspace cosmosmash Message-ID: <20180208071352.GA63012@FreeBSD.org> In-Reply-To: <201802041634.w14GYHVW017651@repo.freebsd.org> References: <201802041634.w14GYHVW017651@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 04, 2018 at 04:34:17PM +0000, Ganael LAPLANCHE wrote: > New Revision: 460940 > URL: https://svnweb.freebsd.org/changeset/ports/460940 > > Log: > Fix build with Clang 6 (C++14 by default) ... by forcing gnu++98 without giving the details of the breakages and why they were not properly fixed instead. :-) I appreciate fixing the build, but USE_CXXSTD should be used only if proper fix would be hard, or the patch would be way too long. Clang 6 might be too pedantic, but it often reveals real bugs in the code, so it's better not simply suppress them with USE_CXXSTD. At least give some details so interested committer could come by and attempt to find a better fix. Thanks, ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180208071352.GA63012>