Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 May 2003 10:58:48 +0200
From:      "Simon L. Nielsen" <simon@nitro.dk>
To:        Marc Fonvieille <blackend@FreeBSD.org>
Cc:        freebsd-doc@FreeBSD.org
Subject:   Re: docs/51897: Add example for disklable for md devices
Message-ID:  <20030507085847.GA394@nitro.dk>
In-Reply-To: <20030507093401.A97412@abigail.blackend.org>
References:  <200305070010.h470A6gY099125@freefall.freebsd.org> <20030507093401.A97412@abigail.blackend.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On 2003.05.07 09:34:01 +0200, Marc Fonvieille wrote:
> On Tue, May 06, 2003 at 05:10:06PM -0700, Simon L. Nielsen wrote:
> [...]
> >  
> >  %%%
> >  Index: mdconfig.8
> >  ===================================================================
> >  RCS file: /home/ncvs/src/sbin/mdconfig/mdconfig.8,v
> >  retrieving revision 1.19
> >  diff -u -d -r1.19 mdconfig.8
> >  --- mdconfig.8	27 Apr 2003 01:46:56 -0000	1.19
> >  +++ mdconfig.8	6 May 2003 23:54:40 -0000
> >  @@ -164,6 +164,18 @@
> >   mount /dev/md10 /tmp
> >   chmod 1777 /tmp
> >   .Ed
> >  +.Pp
> >  +To create a 10MB memory disk named
> >  +.Pa /dev/md0
> >  +with the file
> >  +.Pa somebackingfile
> >  +as backing and label it with normal partitions:
> >  +.Bd -literal -offset indent
> >  +dd if=/dev/zero of=somebackingfile bs=1k count=10k
> >  +mdconfig -a -t vnode -f somebackingfile -u 0
> >  +disklabel -w md0
> 
> We shoould be consistent with other docs (Handbook etc..) i.e.
> disklabel -r -w md0 auto

Actually it was on purpose that I changed that.  As I understand it '-r'
and 'auto' are not needed anymore post GEOM.  The examples in
bsdlabel(8) does not use auto and this is the code handling '-r' :

	case 'r':
		/*
		 * We accept and ignode -r for compatibility with
		 * historically disklabel usage.
		 */
		break;

I would rather say that the rest of the docs should be change not to use
'-r' and 'auto' and perhaps add a compatibility note for FreeBSD < 5.0.

I do agree in general consitency is a very good thing, but in this case
I don't see a reason to keep the old (more complex) format around when
it really is not needed.

-- 
Simon L. Nielsen

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+uMrH8kocFXgPTRwRAj5YAJ4iGQX3h+lXNZRysYArroa7LRdvhgCg01F+
B3H1EKtF/XW+q2Xs71K3LwM=
=m8Jc
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030507085847.GA394>