Date: Thu, 25 Apr 2019 11:46:51 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Kyle Evans <kevans@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346688 - head/sys/net Message-ID: <201904251846.x3PIkpHL049475@gndrsh.dnsmgr.net> In-Reply-To: <CACNAnaGU0ELnCsJ4r33NGsF=ypO1tfMZDadet1D9mvmdMKpe-A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Apr 25, 2019 at 1:24 PM Rodney W. Grimes > <freebsd@gndrsh.dnsmgr.net> wrote: > > > > [ Charset UTF-8 unsupported, converting... ] > > > Author: kevans > > > Date: Thu Apr 25 18:22:22 2019 > > > New Revision: 346688 > > > URL: https://svnweb.freebsd.org/changeset/base/346688 > > > > > > Log: > > > tap(4): Add a MODULE_VERSION > > ^^^ > > > > > > Otherwise tap(4) can be loaded by loader despite being compiled into the > > > kernel, causing a panic as things try to double-initialize. > > > > > > PR: 220867 > > > MFC after: 3 days > > > > > > Modified: > > > head/sys/net/if_tap.c > > ^^^ > > > > > > Modified: head/sys/net/if_tap.c > > > ============================================================================== > > > --- head/sys/net/if_tap.c Thu Apr 25 18:13:55 2019 (r346687) > > > +++ head/sys/net/if_tap.c Thu Apr 25 18:22:22 2019 (r346688) > > > @@ -180,6 +180,7 @@ SYSCTL_INT(_net_link_tap, OID_AUTO, devfs_cloning, CTL > > > SYSCTL_INT(_net_link_tap, OID_AUTO, debug, CTLFLAG_RW, &tapdebug, 0, ""); > > > > > > DEV_MODULE(if_tap, tapmodevent, NULL); > > ^^^ > > > +MODULE_VERSION(if_tun, 1); > > ^^^ > > If wrong, ok, please fix, if correct, please this needs a very > > complete comment as to what it is if_tun. > > > > *sigh* > > I had one job to do, and I goofed it. Thanks for pointing that out... Well it is 25/27 correct :-) > Kyle Evans -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904251846.x3PIkpHL049475>