Date: Sat, 16 Mar 2019 01:34:58 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, Chuck Tuffli <chuck@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve Message-ID: <CAOfEmZjoQS3QD3J8S0oj7_%2ByDyY79nLxKDmCSKnRoTbw9duNRQ@mail.gmail.com> In-Reply-To: <201903151727.x2FHR4ls031294@gndrsh.dnsmgr.net> References: <CANCZdfqFCrVVgpY4cuFwpTHwigXcE7L=aL_44Cy4KY2G4WuP0g@mail.gmail.com> <201903151727.x2FHR4ls031294@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Em s=C3=A1b, 16 de mar de 2019 =C3=A0s 01:27, Rodney W. Grimes < freebsd@gndrsh.dnsmgr.net> escreveu: > > On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > > > freebsd@gndrsh.dnsmgr.net> > > > > wrote: > > > > > > > > > > Author: chuck > > > > > > Date: Fri Mar 15 02:11:28 2019 > > > > > > New Revision: 345171 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > > > > > > > Log: > > > > > > Fix bhyve PCIe capability emulation > > > > > > > > > > > > PCIe devices starting with version 1.1 must set the Role-Base= d > > > Error > > > > > > Reporting bit. > > > > > > > > > > > > And while we're in the neighborhood, generalize the code > assigning > > > the > > > > > > device type. > > > > > > > > > > > > Reviewed by: imp, araujo, rgrimes > > > > > > Approved by: imp (mentor) > > > > > > MFC after: 1 week > > > > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > > > > > > > This code requires maintainer approval before a commit, > > > > > though this was well reviewed that doesnt exclude it > > > > > from the MAINTAINERS entry. > > > > > > > > > > Leave it for now, I am sure jhb or thyco are fine with it, > > > > > this is just a heads up FYI for future commits. > > > > > > > > > > Bhyve code has been and still is under a fairly tight > > > > > MAINTAINER status. > > > > > > > > > > > > > There is no such thing as a hard lock in FreeBSD. This sounds like > you > > > are > > > > advocating for that, but that's not the case. > > > > > > > > Stop this stupid nitpicking for single line commits. We don't have > that > ^^^^^^ > > Thank you for calling my actions stupid, in effect demoralizing me with > the label that includes. I may nit pick, but I never call people degradi= ng > names on a public list. > > Also it only takes a single like to make a bug or problem, > it would help to not consider single line changes any less or > any more important or potentially damaging. > > > > > culture any more and it's really pissing a lot of people off. > > > > > > > > The MAINTAINERS file even says this: > > > > > > > > Please note that the content of this file is strictly advisory. > > > > > > > > And the entry for bhyve doesn't say things are mandatory, just > requested. > > > > > > > > Jumping on people's case like this, for a review you yourself were > on and > > > > approved but made no mention of seeking further review / approval, = is > > > > demotivating and toxic. Please stop. > > > > > > I explicitly DID add jhb to the review. > > > I also explicitly did not mark the bhyve# box that is added by > > > the hearald rules. > > > > > > I did not jump on him, I informed him of the entry, and told him to > leave > > > it. > > > You how ever have infact jumped on me, repeatedly, if you want to tal= k > > > about > > > discouraging tones of behavior I suggest you look at yourself as well= . > > > > > > > Weird that so many other people in the thread read it the same way that= I > > did, and not only this time. That suggests that you're not aware that > your > > behavior is annoying others, which I contend is a problem that needs > > looking into. > > If you have a pre conceived notion or opinion about anything I say, > and I contend that many do, you well always hear it in that tone. This i= s > the rose colored glasses problem. I can not fix that what you hear is > not what I said. > > I speak frankly and without political or other polish to my words, > which at times do make them sound harsh or overly direct. I think > we both actually do that, and, imho, that is better than trying to > sugar coat stuff and be all polite and indirect about things. > > > As always, I'm open to constructive, actionable feedback about my > actions. > > I have tried above. > > > Warner > > > > Warner > > > > > head/usr.sbin/bhyve/pci_emul.c > > > > > > > > > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > > > > > > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > > > > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 > > > > > (r345170) > > > > > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 > > > > > (r345171) > > > > > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst > *pi, int > > > > > type) > > > > > > bzero(&pciecap, sizeof(pciecap)); > > > > > > > > > > > > pciecap.capid =3D PCIY_EXPRESS; > > > > > > - pciecap.pcie_capabilities =3D PCIECAP_VERSION | > > > PCIEM_TYPE_ROOT_PORT; > > > > > > + pciecap.pcie_capabilities =3D PCIECAP_VERSION | type; > > > > > > + /* Devices starting with version 1.1 must set the RBER bi= t > */ > > > > > > + if (PCIECAP_VERSION >=3D 1) > > > > > > + pciecap.dev_capabilities =3D PCIEM_CAP_ROLE_ERR_R= PT; > > > > > > pciecap.link_capabilities =3D 0x411; /* gen1, x1 */ > > > > > > pciecap.link_status =3D 0x11; /* gen1, x1 */ > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Rod Grimes > > > > > rgrimes@freebsd.org > > > > > > > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org > > Rod, again, I don't really want to be rude!!! But have you tried to write a blog or something like that with the ideas that you have instead to write an email and press send? Sometimes we are eager to reply every each email, but if we wait for a while that desire disappears and we will realize if we send that email or not would not change anything. I'm not trying to be sarcastic here, my point is, somebody commit something and someone else replies in public is because there is something really wrong and needs everybody attention. Maybe if you really think there is something wrong, first reply in private to that person and then escalete to public if the matters were not solved. Best, -- --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZjoQS3QD3J8S0oj7_%2ByDyY79nLxKDmCSKnRoTbw9duNRQ>