Date: Mon, 21 Apr 2025 10:27:09 -0400 From: Mark Johnston <markj@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: b7527823fdcc - main - vm_page: Bump __FreeBSD_version for removal of vm_page_next() and _prev Message-ID: <aAZVvSdVpu9VZTeT@nuc> In-Reply-To: <4a521ab3-8a40-4be6-bb06-51ca4e15febe@FreeBSD.org> References: <202504191356.53JDu2Zc011615@gitrepo.freebsd.org> <4a521ab3-8a40-4be6-bb06-51ca4e15febe@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 21, 2025 at 10:23:21AM -0400, John Baldwin wrote: > On 4/19/25 09:56, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=b7527823fdcc29f0da9c17152dbb062eeb18244d > > > > commit b7527823fdcc29f0da9c17152dbb062eeb18244d > > Author: Mark Johnston <markj@FreeBSD.org> > > AuthorDate: 2025-04-19 13:49:48 +0000 > > Commit: Mark Johnston <markj@FreeBSD.org> > > CommitDate: 2025-04-19 13:55:37 +0000 > > > > vm_page: Bump __FreeBSD_version for removal of vm_page_next() and _prev > > Out-of-tree code needs to be modified to use iterators after commit > > a3a88ed22cb1. > > Fixes: a3a88ed22cb1 ("vm_page: drop prev and next") > > Hmm, would it be better for out-of-tree code to use the __FreeBSD_version that > introduces the new API as the version to switch behavior on rather than the > removal of the old API? I tend to follow this practice when patching ports for > API changes in new-bus, etc. In this case, I'm not sure that would be better: the iterator interface has changed a bit since it was introduced and in particular the layout of the iterator structure -- part of the KBI -- has changed since it was introduced. So, using an old value of __FreeBSD_version felt a bit sketchy here.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aAZVvSdVpu9VZTeT>