Date: Wed, 8 Jan 1997 21:45:20 +1100 From: Bruce Evans <bde@zeta.org.au> To: current@freebsd.org, nate@mt.sri.com Subject: Re: Interrupt masks??? Message-ID: <199701081045.VAA31604@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
[>Questions for others to answer.] >ps. Does someone want to review this patch for me? The code uses >INTRMASK above, so why not INTRUNMASK below? > >Index: pcibus.c >=================================================================== >RCS file: /home/CVS/src/sys/i386/isa/pcibus.c,v >retrieving revision 1.27 >diff -u -r1.27 pcibus.c >--- pcibus.c 1996/10/30 22:38:55 1.27 >+++ pcibus.c 1997/01/08 06:25:35 >@@ -519,7 +519,7 @@ > if (! (*maskptr & mask)) > return (-1); > >- *maskptr &= ~mask; >+ INTRUNMASK(*maskptr,mask); > update_intr_masks(); > > return (0); > The code is certainly inconsistent. I think the INTR*MASK macros should go away. They just obfuscate a C idiom. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701081045.VAA31604>