Date: Fri, 15 Feb 2019 09:22:27 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Mark Johnston <markj@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344129 - head Message-ID: <3415ED8D-6831-4EAA-97DB-7E45185E8B82@gmail.com> In-Reply-To: <CANCZdfrDOptYibERM4JfOk77Tmn2cao5G5MRrSYZN4sfwHt-fQ@mail.gmail.com> References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> <CANCZdfrDOptYibERM4JfOk77Tmn2cao5G5MRrSYZN4sfwHt-fQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 14, 2019, at 19:08, Warner Losh <imp@bsdimp.com> wrote: >=20 >> On Thu, Feb 14, 2019, 1:42 PM Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmg= r.net wrote: >> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: >> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < >> > > > > Differential Review: https://reviews.freebsd.org/D19193 >> > > > >> > > > You sited a differential, but not give any attribution >> > > > to the external source :-( >> > > > >> > >=20 >> > > The differential review has that information. >> >=20 >> > External contributors should be recognized by having their names appear= >> > in the commit logs. >>=20 >> We even bother to put a special line in the commit template >> for this. Further it has been standard operating procedure >> for at least as long as I have been back that submitters >> are infact recognized in commit messages. >>=20 >> You have, again, summarily dismissed valid feedback. >=20 >=20 > The problem is that was a trivial commit. And you offered not one, but two= complaints about adding an 'e' to the updating file. That's what pissed me o= ff. It's advice that might be correct, but was so far over the top, in publi= c, for such a trivial commit. That's why I got mad: it added no value and se= emed nit picky and pretty. So I lost it. I shouldn't have, but I did.=20 >=20 > I'm sorry for my cool. Thank you both Rod and Warner for the reply. Thank you Rod for noting that src-committers was a public list; I thought it= was private to FreeBSD src committers. I replied to this thread because while I agree with what you said, I felt th= at the reaction and forum were not in proportion to what happened :/. More than a handful of threads lately have become heated to a point that con= cerns me about inter-developer relations and perception outside of the commu= nity. I have taken part in some of the discussions, potentially contributing= to the overall issue. I=E2=80=99m happy with the eventual outcome, but I hope that we, as a group,= can do better next time to avoid these situations and be kinder to one anot= her. Many of the recent issues (while important in aggregate) seem minor (in= disaggregate). All the best, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3415ED8D-6831-4EAA-97DB-7E45185E8B82>