Date: Tue, 29 Dec 2020 16:38:08 -0800 From: Ryan Libby <rlibby@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 Message-ID: <CAHgpiFyQrDcNYV-5C6UB0wR6r_bpww4PobMBv_Hq15FT_kfN9Q@mail.gmail.com> In-Reply-To: <CACNAnaEoyoU4Caht1ZceUtSS3CAr-UG7O8amuEu_XpnzKQ8VBA@mail.gmail.com> References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> <CACNAnaEoyoU4Caht1ZceUtSS3CAr-UG7O8amuEu_XpnzKQ8VBA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 29, 2020 at 3:32 PM Kyle Evans <kevans@freebsd.org> wrote: > > Hmm, I hadn't done this because we still have in-tree GCC4.2. Might want to go ahead and skip these tests entirely a level up for 4.2. > Ah, thanks for the reminder. I'll take another look re in-tree gcc. Based on the other commits I've MFC'd, I'm pretty sure it's been broken for months anyway, but I'll see what I can do if the fixes are easy. > On Tue, Dec 29, 2020, 17:07 Ryan Libby <rlibby@freebsd.org> wrote: >> >> The branch stable/12 has been updated by rlibby: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=269b7d8ac1e533a1f214904ab7bce50f5c14fe3e >> >> commit 269b7d8ac1e533a1f214904ab7bce50f5c14fe3e >> Author: Kyle Evans <kevans@FreeBSD.org> >> AuthorDate: 2020-03-05 22:45:16 +0000 >> Commit: Ryan Libby <rlibby@FreeBSD.org> >> CommitDate: 2020-12-29 23:04:40 +0000 >> >> tftpd: tests: raise targeted cstd to c11 >> >> r358556 added alignas() use to the functional tests, which isn't defined >> until C11. Raise the -std to C11 to fix the build under freebsd-gcc{6,9}. >> >> Reported by: mhorne, Jenkins/CI >> >> (cherry picked from commit 924e10b809a9fcbc8688c1b5848f60b48e6103fe) >> --- >> libexec/tftpd/tests/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libexec/tftpd/tests/Makefile b/libexec/tftpd/tests/Makefile >> index 06c5537372a7..9aa420cec1a5 100644 >> --- a/libexec/tftpd/tests/Makefile >> +++ b/libexec/tftpd/tests/Makefile >> @@ -10,5 +10,6 @@ TEST_METADATA.functional+= timeout=15 >> >> LIBADD= util >> WARNS?= 6 >> +CSTD= c11 >> >> .include <bsd.test.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFyQrDcNYV-5C6UB0wR6r_bpww4PobMBv_Hq15FT_kfN9Q>