Date: Tue, 21 Feb 2023 12:06:45 +0100 From: Daniel Engberg <diizzy@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 23e0e7b1c30f - main - multimedia/mediainfo: Use all-in-one tarball Message-ID: <8ee5d9f1fb5230cf4e0eb4a00deb6c4b@FreeBSD.org> In-Reply-To: <CAMHz58Qi9mdddkE0f30N_2J-7QE628DkRt499iYRQMsvhyoT4g@mail.gmail.com> References: <202301301306.30UD63Np053142@gitrepo.freebsd.org> <a499acc17d7f0a4151dcc459f09bffef@FreeBSD.org> <CAMHz58Qi9mdddkE0f30N_2J-7QE628DkRt499iYRQMsvhyoT4g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=_b9121bd53bd356bf789f0b9c9d82e8f3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, ...but it also says: "Quite often, software being ported uses the CR/LF convention in source files. This may cause problems with further patching, compiler warnings, or script execution (like /bin/sh^M not found.) To quickly convert all files from CR/LF to just LF, add this entry to the port Makefile" Best regards, Daniel On 2023-02-20 19:33, Po-Chuan Hsieh wrote: > On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg <diizzy@freebsd.org> > wrote: > >> Hi, >> >> Porters Handbook (indirectly) recommends you to sanitize sources. >> https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements > > Do you mean the removal of USES=dos2unix? > This port does not install any text file but only 1 binary executable. > Therefore USES=dos2unix is unnecessary. > > I also checked that the generated bin/mediainfo are identical. > >> Best regards, >> Daniel >> >> On 2023-01-30 14:06, Po-Chuan Hsieh wrote: >>> The branch main has been updated by sunpoet: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291 >>> >>> commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291 >>> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >>> AuthorDate: 2023-01-30 12:27:47 +0000 >>> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >>> CommitDate: 2023-01-30 12:59:06 +0000 >>> >>> multimedia/mediainfo: Use all-in-one tarball >>> >>> - Update WWW >>> - Remove unnecessary USES=dos2unix >>> --- >>> multimedia/mediainfo/Makefile | 20 +++++++++----------- >>> multimedia/mediainfo/distinfo | 6 +++--- >>> 2 files changed, 12 insertions(+), 14 deletions(-) >>> >>> diff --git a/multimedia/mediainfo/Makefile >>> b/multimedia/mediainfo/Makefile >>> index 5766752579b5..9b7c3737d89f 100644 >>> --- a/multimedia/mediainfo/Makefile >>> +++ b/multimedia/mediainfo/Makefile >>> @@ -1,13 +1,14 @@ >>> PORTNAME= mediainfo >>> -DISTVERSION= 22.12 >>> +PORTVERSION= 22.12 >>> CATEGORIES= multimedia >>> -MASTER_SITES= >>> https://mediaarea.net/download/source/${PORTNAME}/${DISTVERSION}/ [1] >>> \ >>> +MASTER_SITES= >>> https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ [2] >>> \ >>> LOCAL/sunpoet >>> -DISTNAME= ${PORTNAME}_${DISTVERSION} >>> +DISTNAME= MediaInfo_CLI_${PORTVERSION}_GNU_FromSource >>> >>> MAINTAINER= sunpoet@FreeBSD.org >>> COMMENT= Provides technical and tag information for video and >>> audio >>> files >>> -WWW= https://mediaarea.net/en/MediaInfo >>> +WWW= https://mediaarea.net/en/MediaInfo \ >>> + https://github.com/MediaArea/MediaInfo >>> >>> LICENSE= BSD2CLAUSE >>> LICENSE_FILE= ${WRKSRC}/../../../License.html >>> @@ -15,17 +16,14 @@ LICENSE_FILE= ${WRKSRC}/../../../License.html >>> LIB_DEPENDS= libmediainfo.so:multimedia/libmediainfo \ >>> libzen.so:multimedia/libzen >>> >>> -USES= autoreconf compiler:c++11-lang cpe dos2unix >>> libtool pathfix \ >>> - pkgconfig tar:xz >>> +USES= compiler:c++11-lang cpe libtool pathfix >>> pkgconfig tar:xz >>> >>> GNU_CONFIGURE= yes >>> -USE_CXXSTD= c++11 >>> USE_LDCONFIG= yes >>> -CPE_VENDOR= mediaarea >>> -DOS2UNIX_GLOB= *.c *.cpp *.h >>> -DOS2UNIX_WRKSRC= ${WRKDIR} >>> >>> PLIST_FILES= bin/mediainfo >>> -WRKSRC= ${WRKDIR}/MediaInfo/Project/GNU/CLI >>> +WRKSRC= >>> ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI >>> + >>> +CPE_VENDOR= mediaarea >>> >>> .include <bsd.port.mk [3]> >>> diff --git a/multimedia/mediainfo/distinfo >>> b/multimedia/mediainfo/distinfo >>> index 0d9caebdc92b..995778948454 100644 >>> --- a/multimedia/mediainfo/distinfo >>> +++ b/multimedia/mediainfo/distinfo >>> @@ -1,3 +1,3 @@ >>> -TIMESTAMP = 1672606752 >>> -SHA256 (mediainfo_22.12.tar.xz) = >>> 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc >>> -SIZE (mediainfo_22.12.tar.xz) = 2026408 >>> +TIMESTAMP = 1674589524 >>> +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = >>> e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947 >>> +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = 3352944 Links: ------ [1] https://mediaarea.net/download/source/$%7BPORTNAME%7D/$%7BDISTVERSION%7D/ [2] https://mediaarea.net/download/binary/mediainfo/$%7BPORTVERSION%7D/ [3] http://bsd.port.mk --=_b9121bd53bd356bf789f0b9c9d82e8f3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset= =3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen= eva,sans-serif'> <p>Hi,</p> <p>...but it also says:</p> <p>"Quite often, software being ported uses the CR/LF convention in source = files. This may cause problems with further patching, compiler warnings, or= script execution (like <code>/bin/sh^M not found</code>.) To quickly conve= rt all files from CR/LF to just LF, add this entry to the port <span class= =3D"filename">Makefile</span>"</p> <p>Best regards,</p> <p>Daniel</p> <p id=3D"reply-intro">On 2023-02-20 19:33, Po-Chuan Hsieh wrote:</p> <blockquote type=3D"cite" style=3D"padding: 0 0.4em; border-left: #1010ff 2= px solid; margin: 0"> <div id=3D"replybody1"> <div dir=3D"ltr"> <div dir=3D"ltr">On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg <<a href= =3D"mailto:diizzy@freebsd.org" rel=3D"noreferrer">diizzy@freebsd.org</a>>= ; wrote:</div> <div class=3D"v1gmail_quote"> <blockquote class=3D"v1gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; bor= der-left: 1px solid #cccccc; padding-left: 1ex;">Hi,<br /><br />Porters Han= dbook (indirectly) recommends you to sanitize sources.<br /><a href=3D"http= s://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-r= eplacements" target=3D"_blank" rel=3D"noopener noreferrer">https://docs.fre= ebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements<= /a></blockquote> <div> </div> <div>Do you mean the removal of USES=3Ddos2unix?</div> <div>This port does not install any text file but only 1 binary executable.= </div> <div>Therefore USES=3Ddos2unix is unnecessary.</div> <div> </div> <div>I also checked that the generated bin/mediainfo are identical.</d= iv> <div> </div> <blockquote class=3D"v1gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; bor= der-left: 1px solid #cccccc; padding-left: 1ex;"><br />Best regards,<br />D= aniel<br /><br />On 2023-01-30 14:06, Po-Chuan Hsieh wrote:<br />> The b= ranch main has been updated by sunpoet:<br />> <br />> URL:<br />>= <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D23e0e7b1c30fc6f8695= 7a7428e51a5ea9c594291" target=3D"_blank" rel=3D"noopener noreferrer">https:= //cgit.FreeBSD.org/ports/commit/?id=3D23e0e7b1c30fc6f86957a7428e51a5ea9c594= 291</a><br />> <br />> commit 23e0e7b1c30fc6f86957a7428e51a5ea9c59429= 1<br />> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.o= rg><br />> AuthorDate: 2023-01-30 12:27:47 +0000<br />> Commit:&nb= sp; Po-Chuan Hsieh <sunpoet@FreeBSD.org><br />> Commi= tDate: 2023-01-30 12:59:06 +0000<br />> <br />> mu= ltimedia/mediainfo: Use all-in-one tarball<br />> <br />>  = ; - Update WWW<br />> - Remove unnecessary USES= =3Ddos2unix<br />> ---<br />> multimedia/mediainfo/Makefile | 2= 0 +++++++++-----------<br />> multimedia/mediainfo/distinfo | = ; 6 +++---<br />> 2 files changed, 12 insertions(+), 14 deletions(= -)<br />> <br />> diff --git a/multimedia/mediainfo/Makefile <br />&g= t; b/multimedia/mediainfo/Makefile<br />> index 5766752579b5..9b7c3737d8= 9f 100644<br />> --- a/multimedia/mediainfo/Makefile<br />> +++ b/mul= timedia/mediainfo/Makefile<br />> @@ -1,13 +1,14 @@<br />> PORT= NAME=3D mediainfo<br />> -DISTVERSION=3D 22.12<br />> +P= ORTVERSION=3D 22.12<br />> CATEGORIES=3D multimedia<br />>= ; -MASTER_SITES=3D <a href=3D"https://mediaarea.= net/download/source/$%7BPORTNAME%7D/$%7BDISTVERSION%7D/" target=3D"_blank" = rel=3D"noopener noreferrer">https://mediaarea.net/download/source/${PORTNAM= E}/${DISTVERSION}/</a><br />> \<br />> +MASTER_SITES=3D = <a href=3D"https://mediaarea.net/download/binary/mediainfo/$%= 7BPORTVERSION%7D/" target=3D"_blank" rel=3D"noopener noreferrer">https://me= diaarea.net/download/binary/mediainfo/${PORTVERSION}/</a> <br />> \<br /= >> LOCAL/sunpoet<b= r />> -DISTNAME=3D ${PORTNAME}_${DISTVERSION}<br />> +DI= STNAME=3D MediaInfo_CLI_${PORTVERSION}_GNU_FromSource<br />>= ; <br />> MAINTAINER=3D sunpoet@FreeBSD.org<br />> = COMMENT=3D Provides technical and tag information for vi= deo and audio <br />> files<br />> -WWW=3D = <a href=3D"https://mediaarea.net/en/MediaInfo" target=3D"_blank" rel= =3D"noopener noreferrer">https://mediaarea.net/en/MediaInfo</a><br />> += WWW=3D <a href=3D"https://mediaarea.net/en= /MediaInfo" target=3D"_blank" rel=3D"noopener noreferrer">https://mediaarea= =2Enet/en/MediaInfo</a> \<br />> + &nb= sp; <a href=3D"https://github.com/MediaArea/MediaInfo" target=3D"_bla= nk" rel=3D"noopener noreferrer">https://github.com/MediaArea/MediaInfo</a><= br />> <br />> LICENSE=3D BSD2CLAUSE<br />&g= t; LICENSE_FILE=3D ${WRKSRC}/../../../Lice= nse.html<br />> @@ -15,17 +16,14 @@ LICENSE_FILE=3D $= {WRKSRC}/../../../License.html<br />> LIB_DEPENDS=3D libmediainfo.= so:multimedia/libmediainfo \<br />> &n= bsp; libzen.so:multimedia/libzen<br />> <br />> -USES=3D= autoreconf compiler= :c++11-lang cpe dos2unix libtool pathfix \<br />> - = pkgconfig tar:xz<br />> +USES=3D = compiler:c++11-lang cpe libtool = pathfix pkgconfig tar:xz<br />> <br />> GNU_CONFIGURE=3D = yes<br />> -USE_CXXSTD=3D c++11<br />> = ; USE_LDCONFIG=3D yes<br />> -CPE_VENDOR=3D&n= bsp; mediaarea<br />> -DOS2UNIX_GLOB=3D *.c *.= cpp *.h<br />> -DOS2UNIX_WRKSRC=3D ${WRKDIR}<br />>= ; <br />> PLIST_FILES=3D bin/mediainfo<br />> -WRKSRC=3D = ${WRKDIR}/MediaInfo/Project/GNU/C= LI<br />> +WRKSRC=3D ${W= RKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI<br />> +<b= r />> +CPE_VENDOR=3D mediaarea<br />> <br />> .include= <<a href=3D"http://bsd.port.mk" target=3D"_blank" rel=3D"noopener noref= errer">bsd.port.mk</a>><br />> diff --git a/multimedia/mediainfo/dist= info <br />> b/multimedia/mediainfo/distinfo<br />> index 0d9caebdc92= b..995778948454 100644<br />> --- a/multimedia/mediainfo/distinfo<br />&= gt; +++ b/multimedia/mediainfo/distinfo<br />> @@ -1,3 +1,3 @@<br />>= -TIMESTAMP =3D 1672606752<br />> -SHA256 (mediainfo_22.12.tar.xz) =3D<b= r />> 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc<b= r />> -SIZE (mediainfo_22.12.tar.xz) =3D 2026408<br />> +TIMESTAMP = =3D 1674589524<br />> +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz= ) =3D<br />> e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef11= 06947<br />> +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) =3D 33529= 44</blockquote> </div> </div> </div> </blockquote> <p><br /></p> </body></html> --=_b9121bd53bd356bf789f0b9c9d82e8f3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8ee5d9f1fb5230cf4e0eb4a00deb6c4b>