Date: Fri, 28 Mar 2014 15:35:29 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Ryan Stone <rysto32@gmail.com> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>, Neel Natu <neelnatu@gmail.com> Subject: Re: [PATCH] Support PCIe Alternative RID Interpretation (ARI) Message-ID: <20140328133529.GV21331@kib.kiev.ua> In-Reply-To: <CAFMmRNxQRJ2g9Ohu%2BXgj=tQ=tUrTdMQx1KSdd1k%2BjGMOtCZLEA@mail.gmail.com> References: <CAFMmRNzL3uBZ-djWgpnKi3XDQdq4c1ODAL_8E-Vpy-dPLa-hog@mail.gmail.com> <20140316141216.GA21331@kib.kiev.ua> <CAFMmRNwormaaPXk6rJ-JJGePS6fDNFsdKAfmmW2jGLNRscf1Pw@mail.gmail.com> <CAFgRE9F632zLseG7MobxgV5CdvD0KyMn28CBSwYqVtZKuLBwRw@mail.gmail.com> <CAFMmRNwCGVhyn5cU29YpsVq44Q5i51C38GVsz33xGeqNyemx0Q@mail.gmail.com> <20140319140236.GM21331@kib.kiev.ua> <CAFMmRNxM1E2aNtZV588V3BGkz1aOaGgAXGbgktYrmzT9M3EyVw@mail.gmail.com> <20140325211355.GG21331@kib.kiev.ua> <CAFMmRNxQRJ2g9Ohu%2BXgj=tQ=tUrTdMQx1KSdd1k%2BjGMOtCZLEA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--V8Y3+xXnhQGsvjWT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 27, 2014 at 02:48:36PM -0400, Ryan Stone wrote: > On Tue, Mar 25, 2014 at 5:13 PM, Konstantin Belousov > <kostikbel@gmail.com> wrote: > > Well, either the interface I described is provided by pci core, or > > iommu has to de-facto implement it itself. IMO it is clearer to have > > it in pci, but I do not want to block your work on this. >=20 > Yes, but this amounts to some simple masking and shifting on the RID. > I don't think that's a very high burden. Well, as I learned during iommu development, a typo there could lay unnoticed for long time and than beat. This is due to most modern systems being PCIe and slot/function often equal to zero, or at least function equal to zero. >=20 > > I mean, that slot and func should be obtained using pci accessors where > > needed. It is definitely not perf-critical, and I dislike having both > > bsf and rid in the context structure more, then using accessors. >=20 > Ok, I've updated the DMAR patch to use pci accessors instead. This > required moving the initialization of ctx_tag.owner earlier in the > initialization of the DMAR ctx, but beyond that the change was > trivial. What is the URL ? --V8Y3+xXnhQGsvjWT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTNXqgAAoJEJDCuSvBvK1BWnkP/2HeUh/ShjHd73WazR3M99qu n4dblfySmM2LSMXfoQxrO1H5/lUQQneAmAEw5Bt3qEVEHPSvItyEPxThnqf8DmCe JzbXm9+lLLK8ZfdGCMVXGOEmo5+fZb34TtV2JJo+x9rNRYeWHtwGiX8FMBfIi4Yo l//DzAMgs8jqgiCHxYZ0pcCsFTogGFpTWU7WyHYkEWbOTTvm3mz2dGINMH6rkCuE zzHMOAClXllW5vhZCxlQ9xh7axeATIrpFMB6n3L08RDoKGxB3eGZI3A9xXUEijOy 8gf87hwhsZy8MnaKMU9dQzB7Ii9T0gKTdeV+Ez9IYTce0RoOUEZB2LnZX+NR/SuX U6orKLJLuVgnfWhrKNbyAoCpeDChdL78Jn0qJ96vCMd6HiJliHy3iZacYXkksJkY DGqpjnJDFC+7IerR+Lv4y8JLYPCjOm5+c8tFngL5zWzQujveajXQfHN16FsPQ8jU JdAGsVSVdMdnxTcUoCxgVYz51ecyoPuzor83kz4+DQbPauGh7EYRbxyxAkPVe0B7 BA5hHqFZSLKIGCyQZI3ESoR8muXtm2UbiU37kFeaTLd0njepFEF/rYtkDgdBz2op nPQYdjkYWfs4mJCQcrq8k7bNmqBFKdAk/jo9Oi4dHTttdYooo4j22zGDb0+6FIAZ dJ33sK40EJbI15FVla3Z =1E/x -----END PGP SIGNATURE----- --V8Y3+xXnhQGsvjWT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140328133529.GV21331>