Date: Sun, 21 Dec 2008 13:17:51 +0800 From: Ganbold <ganbold@micom.mng.net> To: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, Scott Long <scottl@samsco.org> Subject: Re: mutex ATAPICAM lock owned at /usr/src/sys/cam/cam_periph.c:316 Message-ID: <494DD17F.5090903@micom.mng.net> In-Reply-To: <494DBBEC.7080107@micom.mng.net> References: <494DBBEC.7080107@micom.mng.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Ganbold wrote: > Hi, > > I got panic today with recent CURRENT. > > All relevant infos are here: > > http://people.freebsd.org/~ganbold/ddb.txt > http://people.freebsd.org/~ganbold/msgbuf.txt > http://people.freebsd.org/~ganbold/panic.txt > http://people.freebsd.org/~ganbold/version.txt > Replying myself, I guess there should be unlock before releasing the periph at scsi_pass.c: --- /var/current/src/sys/cam/scsi/scsi_pass.c 2008-11-22 16:58:50.000000000 +0800 +++ /usr/src/sys/cam/scsi/scsi_pass.c 2008-12-21 12:59:36.000000000 +0800 @@ -347,8 +347,10 @@ if ((softc->flags & PASS_FLAG_OPEN) == 0) { softc->flags |= PASS_FLAG_OPEN; } else { - /* Device closes aren't symmertical, so fix up the refcount */ + /* Device closes aren't symmetrical, so fix up the refcount */ + cam_periph_unlock(periph); cam_periph_release(periph); + return(EINVAL); } cam_periph_unlock(periph); I guess it needs to be committed. Correct me if I'm wrong here. thanks, Ganbold > thanks, > > Ganbold > > -- Bower's Law: Talent goes where the action is.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?494DD17F.5090903>