Date: Mon, 31 Mar 2025 11:14:04 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Enji Cooper <ngie@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e24279e0f9e2 - main - Remove mentions of ENOSYS added in d97e44784bb5 Message-ID: <25967c7b-79c0-4883-8b92-86e58201589b@FreeBSD.org> In-Reply-To: <202503280240.52S2elHG075912@gitrepo.freebsd.org> References: <202503280240.52S2elHG075912@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/27/25 21:40, Enji Cooper wrote: > The branch main has been updated by ngie: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e24279e0f9e28ba0c1920cb539fc357568790c0a > > commit e24279e0f9e28ba0c1920cb539fc357568790c0a > Author: Enji Cooper <ngie@FreeBSD.org> > AuthorDate: 2025-03-27 19:26:59 +0000 > Commit: Enji Cooper <ngie@FreeBSD.org> > CommitDate: 2025-03-28 02:40:07 +0000 > > Remove mentions of ENOSYS added in d97e44784bb5 > > aio(4) is a hard requirement in the kernel as of f3215338ef82. The > scenario that the patch was submitted for is no longer possible. > > This isn't a straight up revert since the previous change also addressed > some minor issues. > > PR: 190942 > Reported by: asomers > MFC after: 2 weeks > MFC with: d97e44784bb5 > Fixes: d97e44784bb5 ("aio_*(2): mention ENOSYS under ERRORS") > Differential Revision: https://reviews.freebsd.org/D49541 FWIW, I think it would have been cleaner to do a full revert and then do a followup commit applying the other changes. You had to do the followup commit anyway to bump .Dd. Not anything to change here, but something to consider in the future. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25967c7b-79c0-4883-8b92-86e58201589b>