Date: Thu, 15 Jul 2004 23:04:20 -0700 (PDT) From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/69139: suphp 0.5.2 no longer builds on 4.x (cannot locate suphp.o object) Message-ID: <200407160604.i6G64KNP091310@pentarou.parodius.com> Resent-Message-ID: <200407160610.i6G6APNe004078@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 69139
>Category: ports
>Synopsis: suphp 0.5.2 no longer builds on 4.x (cannot locate suphp.o object)
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Fri Jul 16 06:10:25 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Chadwick
>Release: FreeBSD 4.10-PRERELEASE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD pentarou.parodius.com 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #0: Wed May 5 03:33:17 PDT 2004 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386
>Description:
Port does not build on 4.x machines; builds fine on 5.x. This was caused
by my removal of USE_GMAKE (it seems 5.x make supports expansion modifiers
for targets/objects such as '%.o : %.c' (all *.o files depend on *.c files),
while 4.x does not).
I fixed this by using a more proper method; specifying the objects in OBJS,
basing a translation from SRCS (using the ":/=" assignment modifiers).
>How-To-Repeat:
Try to build on a 4.x box.
>Fix:
Apply below patch. This will update suphp/files/patch-src::Makefile.in
and will then work on 4.x and 5.x without relying on GNU make.
If this patch does not work, please let me know ASAP and I'll include the
actual replacement file (suphp/files/patch-src::Makefile.in) itself.
diff -ruN suphp.orig/files/patch-src::Makefile.in suphp/files/patch-src::Makefile.in
--- suphp.orig/files/patch-src::Makefile.in Mon Aug 25 05:13:36 2003
+++ suphp/files/patch-src::Makefile.in Thu Jul 15 22:56:23 2004
@@ -1,10 +1,35 @@
--- src/Makefile.in.orig Mon Aug 25 11:50:48 2003
-+++ src/Makefile.in Mon Aug 25 11:50:55 2003
-@@ -39,7 +39,6 @@
++++ src/Makefile.in Thu Jul 15 22:52:13 2004
+@@ -28,11 +28,13 @@
+ INCLUDES = -I$(top_srcdir)/src
+ RM = rm -f
+
++SRCS= suphp.c filesystem.c check.c error.c log.c compat.c
++OBJS= ${SRCS:.c=.o}
++
+ all: suphp suphp.mod
+
+-suphp: suphp.o filesystem.o check.o error.o log.o compat.o
+- $(CC) $(LDFLAGS) $(DEFS) -o suphp \
+- suphp.o filesystem.o check.o error.o log.o compat.o
++suphp: ${OBJS}
++ $(CC) $(LDFLAGS) $(DEFS) -o suphp ${OBJS}
+
+ suphp.mod:
+ @if test "$(APXS)" != "/notfound/"; then \
+@@ -49,7 +51,6 @@
fi
install: suphp suphp.mod
- $(INSTALL_PROGRAM) -d $(DESTDIR)$(sbindir)
$(INSTALL_PROGRAM) -m 4755 suphp $(DESTDIR)$(sbindir)/suphp
- @$(MAKE) $(MAKEDEFS) -C apache install
+ @if test "$(APXS)" != "/notfound/"; then \
+ if test "$(APACHE_VERSION_2)" = "true"; then \
+@@ -69,6 +70,6 @@
+ @$(MAKE) $(MAKEDEFS) -C apache clean
+ @$(MAKE) $(MAKEDEFS) -C apache2 clean
+
+-%.o : %.c
++${OBJS}: ${SRCS}
+ $(CC) -c $(CFLAGS) $(DEFS) $(INCLUDES) -o $@ $<
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407160604.i6G64KNP091310>