Date: Mon, 02 Mar 2015 11:13:00 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 196796] [NEW PORT] sysutils/librolegen: Library to generate WebOS system bus role files Message-ID: <bug-196796-13-QFjKFBeAHn@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-196796-13@https.bugs.freebsd.org/bugzilla/> References: <bug-196796-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196796 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|penzin.dev@gmail.com | Summary|New port: |[NEW PORT] |sysutils/librolegen |sysutils/librolegen: |Library to generate WebOS |Library to generate WebOS |system bus role files |system bus role files Keywords| |needs-qa, patch --- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> --- Hi Petr, Upon initial review, I can see at least the following needs fixing: - GH_PROJECT=librolegen is unnecessary, as GH_PROJECT defaults to ${PORTNAME} which is librolegen in this case. - COMMENT should not start with PORTNAME (portlint(8) will tell you this) - INSTALL_TARGET defaults to 'install' as its value, not needed (iirc). - Use BUILD_DEPENDS earlier, and using = rather than += the first time you use it (again portlint(8) will help you here) I would also highly recommend the following QA logs as attachments: - portlint -AC output (you can find it in ports-mgmt/portlint - poudriere testport / bulk -t output. See: [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing-poudriere.html -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196796-13-QFjKFBeAHn>