Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Nov 2011 10:15:44 +0100
From:      Ed Schouten <ed@80386.nl>
To:        Peter Jeremy <peterjeremy@acm.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r227156 - head/usr.bin/cmp
Message-ID:  <20111106091544.GM2258@hoeg.nl>
In-Reply-To: <20111106091003.GA37935@server.vk2pj.dyndns.org>
References:  <201111060814.pA68EGLf008005@svn.freebsd.org> <20111106091003.GA37935@server.vk2pj.dyndns.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--YGQsgxOP0v8GKjPA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Peter Jeremy <peterjeremy@acm.org>, 20111106 10:10:
> That's an interesting spelling of "static".  I presume this is a
> general cleanup of identifier visibility to prevent unexpected
> aliasing - in which case a more general log message may have nicer.

Yes, sorry about that. When I read through the diff, I overlooked that
there were a small number of changes in there that don't mark things
static, but instead mark them extern.

In the case for cmp, simply all the `*flag' variables were marked extern
anyway, so I decided not to deviate from that for `zflag'.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--YGQsgxOP0v8GKjPA
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iQIcBAEBAgAGBQJOtlBAAAoJEG5e2P40kaK7i0sP/0oVG9vV/vCgxOszXXQjh5U2
cXURdBXrPnTfisoOGAFleM8GIDunAal4mZstYK4o1sLvDmhBzy91XahARwS/71bB
StcA4/dKbn1duVEFb+Sc/NKY1V0EbWSe5smDD3PIDUIz6I4pzFhRPeZ6WPUbwDQa
GTkcNzyl7rhtjt+MxHsnVEh2gOQI7JGdg2eJ1/6UMoIte3SDFlQQXpwfnHyAGG9W
p+m96PoTXcnnbFq2hgX2Uf+/p+6av9H9dhqFUTcVTWNVVA/6LWZNlh+HLeqmnfE7
vrYCEhd4th1xYPXi8mhJxjb6mu43dofL68psHWKjrfjSDPY+PFJ39WpRzVtcEaNC
N52fpj7He0RAVYESgAnvly04npX7xHP6oi1y69nbkaid6uTPrfb7D58etIWypFQM
Vmfx6mYj8K2eGM8ECVncSSmDAA5ErO205mHW3uh9OWsTVnkUN5ReCLDr1UKXpIcS
8VPQRmfwRuWVFJvjX+MCZ5gONJILfBcVydYwWqa9wci8PKJ8WE+qZsNY+KVmeUSA
RxjInOh9HDBwj6e7USmTDH69V5TOfHgY+1PlNJMTb6R+dXaVpVEsmWURbEPiYaAX
N/Orrw4VIZinJoNaVlVfYZAnX/kYY+OWBPtTQIZJmDD++yVI4BrbeRvvpqqmKQKb
ryAzraZkO14U90jcyRdW
=o13K
-----END PGP SIGNATURE-----

--YGQsgxOP0v8GKjPA--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111106091544.GM2258>