Date: Thu, 13 Nov 2008 19:05:27 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/contrib/telnet/telnetd ext.h sys_term.c src/libexec/telnetd Makefile Message-ID: <200811131910.mADJATpg066876@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2008-11-13 19:05:27 UTC
FreeBSD src repository
Modified files:
contrib/telnet/telnetd ext.h sys_term.c
libexec/telnetd Makefile
Log:
SVN rev 184935 on 2008-11-13 19:05:27Z by ed
Convert telnetd(8) to use posix_openpt(2).
Some time ago I got some reports MPSAFE TTY broke telnetd(8). Even
though it turned out to be a different problem within the TTY code, I
spotted a small issue with telnetd(8). Instead of allocating PTY's using
openpty(3) or posix_openpt(2), it used its own PTY allocation routine.
This means that telnetd(8) still uses /dev/ptyXX-style devices.
I've also increased the size of line[]. Even though 16 should be enough,
we already use 13 bytes ("/dev/pts/999", including '\0'). 32 bytes gives
us a little more freedom.
Also enable -DSTREAMSPTY. Otherwise telnetd(8) strips the PTY's pathname
to the latest slash instead of just removing "/dev/" (e.g. /dev/pts/0 ->
0, instead of pts/0).
Reviewed by: rink
Revision Changes Path
1.12 +1 -1 src/contrib/telnet/telnetd/ext.h
1.19 +18 -33 src/contrib/telnet/telnetd/sys_term.c
1.33 +2 -1 src/libexec/telnetd/Makefile
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811131910.mADJATpg066876>