Date: Fri, 10 Jun 2005 15:03:44 -0400 From: Stephan Uphoff <ups@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_switch.c sched_4bsd.c Message-ID: <1118430224.27369.54685.camel@palm> In-Reply-To: <d2ec9100101579abd9f49a4515d68a8b@FreeBSD.org> References: <200506091826.j59IQVMe054446@repoman.freebsd.org> <00b08fa8e580e95a2c5ecd95c54a9805@FreeBSD.org> <1118371501.27369.45718.camel@palm> <d2ec9100101579abd9f49a4515d68a8b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2005-06-10 at 12:50, John Baldwin wrote: > On Jun 9, 2005, at 7:45 PM, Stephan Uphoff wrote: > > > On Thu, 2005-06-09 at 19:28, John Baldwin wrote: > >> On Jun 9, 2005, at 11:26 AM, Stephan Uphoff wrote: > >> > >>> ups 2005-06-09 18:26:31 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/kern kern_switch.c sched_4bsd.c > >>> Log: > >>> Fix some race conditions for pinned threads that may cause them to > >>> run > >>> on the wrong CPU. > >>> > >>> Add IPI support for preempting a thread on another CPU. > >>> > >>> MFC after:3 weeks > >> > >> Note that this breaks the compile on non x86 when PREEMPTION isn't on > > > > I compiled/tested it also without PREEMPTION on x86. > > Could you send me the error message? > > I mistyped, I meant when preemption is on. The Alpha tinderbox is > keeling over now due to the missing IPI_PREEMPT. I can try to add > IPI_PREEMPT in next week or so. Thanks - found it. This is a LINT only problem. OK to fix it like this? : RCS file: /cvsroot/src/sys/conf/NOTES,v retrieving revision 1.1322 diff -u -r1.1322 NOTES --- NOTES 9 Jun 2005 18:59:21 -0000 1.1322 +++ NOTES 10 Jun 2005 19:01:55 -0000 @@ -231,7 +231,7 @@ # WITNESS_SKIPSPIN disables the witness checks on spin mutexes. options PREEMPTION options FULL_PREEMPTION -options IPI_PREEMPTION +#options IPI_PREEMPTION options MUTEX_DEBUG options WITNESS options WITNESS_KDB
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1118430224.27369.54685.camel>