Date: Tue, 2 Nov 2010 23:12:55 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: freebsd-stable@freebsd.org, Pete French <petefrench@ticketswitch.com> Subject: Re: hast vs ggate+gmirror sychrnoisation speed Message-ID: <20101102221255.GD2051@garage.freebsd.pl> In-Reply-To: <864oc07r6z.fsf@kopusha.home.net> References: <E1PAlxN-000H5x-Eh@dilbert.ticketswitch.com> <86wrp3wj67.fsf@kopusha.home.net> <20101028163036.GA2347@garage.freebsd.pl> <86lj5i3zjt.fsf@kopusha.home.net> <86d3qr3m0b.fsf@kopusha.home.net> <20101101110100.GI2160@garage.freebsd.pl> <86d3qpqe0m.fsf@zhuzha.ua1> <864oc07r6z.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Nov 01, 2010 at 09:57:08PM +0200, Mikolaj Golub wrote: > > On Mon, 01 Nov 2010 17:06:49 +0200 Mikolaj Golub wrote: > > MG> On Mon, 1 Nov 2010 12:01:00 +0100 Pawel Jakub Dawidek wrote: > > PJD>> I like your patch and I agree of course it is better to send keepalive > PJD>> packets only when connection is idle. The only thing I'd change is to > PJD>> modify QUEUE_TAKE1() macro to take additional argument 'timeout' - if we > PJD>> don't want it to time out, we pass 0. Could you modify your patch? > > MG> Sure :-). Could you look at the updated version? > > MG> Note. So far I have only tested that hastd with this updated patch is > MG> compilable and runnable. I will do normal testing today later when I have > MG> access to my test instances and will report about the results. > > Tested. It works for me. Great. Committed, thanks! -- Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkzQjOcACgkQForvXbEpPzSxUQCg5eXzeeZJNrBvf0Yrej9uMdpZ knwAn3X4CEAxc8DUQeZ8kgwP8mTh0ZP5 =Felz -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101102221255.GD2051>