Date: Wed, 17 Feb 2021 19:15:29 +0100 From: "Kristof Provost" <kp@FreeBSD.org> To: "Daniel Ebdrup Jensen" <debdrup@FreeBSD.org> Cc: freebsd-hackers@freebsd.org Subject: Re: MFCing a src commit if I forgot the MFC tags Message-ID: <CD7124D6-4CA9-4560-A48F-C7D0995C43DE@FreeBSD.org> In-Reply-To: <20210217180400.vcyhf6as4eevnslp@nerd-thinkpad.local> References: <7b466cd67933ddef2d4eb9b6bdd466e1@freebsd.org> <503F17CD-B7CD-4F37-9422-13D6A79C552C@FreeBSD.org> <20210217180400.vcyhf6as4eevnslp@nerd-thinkpad.local>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 Feb 2021, at 19:04, Daniel Ebdrup Jensen wrote: > On Wed, Feb 17, 2021 at 06:58:42PM +0100, Kristof Provost wrote: >> On 17 Feb 2021, at 18:46, Neel Chauhan wrote: >>> I have this commit: = >>> https://cgit.freebsd.org/src/commit/?id=3Da08cdb6cfb1c84b80b5337d46c5= 74b55d0e15c63 >>> >>> This commit enables IPFW NAT to NAT a certain port range on the = >>> outside, much like a Carrier Grade NAT setup. >>> >>> When I committed this, I forgot to add the MFC tags. However, I = >>> would like to MFC this commit. >>> >>> Can I just commit this on my own to stable/12 and stable/1, or is = >>> there something special I need to do? >>> >> MFC tags are indicative, not mandatory. I sometimes end up not MFCing = >> things I=E2=80=99d tagged with an =E2=80=98MFC after=E2=80=99 after al= l. >> It=E2=80=99s perfectly okay to MFC things that don=E2=80=99t have a ta= g. = >> (Although if it=E2=80=99s not your commit it may be a good idea to ask= the = >> author why it wasn=E2=80=99t tagged.) >> >> This commit has been in main long enough to be an MFC candidate, so = >> you can merge it to stable/13 and stable/12 at any time. >> > I always just thought MFC field was a way of ensuring that you get a > notification about it on email? > That=E2=80=99s one effect of it, yes. It also communicates your intention= to = merge this (which is why you get the reminder). It=E2=80=99s not mandatory to follow through on it and lack of the tag do= es = not stop you from merging it after all (but does mean you won=E2=80=99t g= et a = reminder). Best regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CD7124D6-4CA9-4560-A48F-C7D0995C43DE>