Date: Sat, 21 Jan 2012 16:52:52 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Hiroki Sato <hrs@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au>, src-committers@FreeBSD.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs Message-ID: <20120121164200.I2292@besplex.bde.org> In-Reply-To: <CAF6rxg=UH23TreEMzgZVxO_3GB%2B-K3EL02hOSG2DUb0=V-7UBg@mail.gmail.com> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120121103348.Q1254@besplex.bde.org> <CAF6rxg=UH23TreEMzgZVxO_3GB%2B-K3EL02hOSG2DUb0=V-7UBg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1597002112-1327125172=:2292 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Fri, 20 Jan 2012, Eitan Adler wrote: > On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans <brde@optusnet.com.au> wrote= : >> I agree. =C2=A0Never fix vendor code. =C2=A0Especially style bugs in it.= =C2=A0Not all >> vendor code is in contrib. > > I'm sure this is a silly question, but why isn't this utility in a > contrib/ folder? Probably historical, but src/contrib/ still has little more than `file' and lukemftpd from NetBSD. I think those are there mainly because they got portabilized and complicated by their use of autoconfig, so they don't fit naturally in the BSD build framework any more. > [snip other fixes to the api] [for cpucontrol] >> I don't understand this code well enough to fix it. =C2=A0Fixing it requ= ires >> understanding whether the unused variable was unused because of another >> bug. =C2=A0Another bug seems likely here, since there is so much dead co= de. >> Or maybe I'm just confused, and the dead code is actually undead. =C2=A0= It >> is complicated enough for this to be unclear. > > I did not just rely on the compiler - I went through the code manually > to ensure it was correct. It can take too long to see correctness for an apparently-simple change. Bruce --0-1597002112-1327125172=:2292--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120121164200.I2292>