Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 May 2015 12:39:49 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Mikhail Teterin <mi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r387637 - in head/devel/tcllib: . files
Message-ID:  <55660165.3050106@FreeBSD.org>
In-Reply-To: <201505271719.t4RHJXY6010274@svn.freebsd.org>
References:  <201505271719.t4RHJXY6010274@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 5/27/2015 12:19 PM, Mikhail Teterin wrote:
> Author: mi
> Date: Wed May 27 17:19:32 2015
> New Revision: 387637
> URL: https://svnweb.freebsd.org/changeset/ports/387637
>=20
> Log:
>   Rely on critcl port to provide compiled implementations of the
>   modules, where available.
>  =20
>   PR:		195863
>   Approved by:	maintainer (blanket)
>=20
> Added:
>   head/devel/tcllib/files/patch-jpeg   (contents, props changed)
>   head/devel/tcllib/files/patch-json   (contents, props changed)
>   head/devel/tcllib/files/patch-tests   (contents, props changed)
> Modified:
>   head/devel/tcllib/Makefile
>   head/devel/tcllib/pkg-plist
>=20
> Modified: head/devel/tcllib/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/devel/tcllib/Makefile	Wed May 27 16:26:13 2015	(r387636)
> +++ head/devel/tcllib/Makefile	Wed May 27 17:19:32 2015	(r387637)
> @@ -3,6 +3,7 @@
> =20
>  PORTNAME=3D	tcllib
>  PORTVERSION=3D	1.17
> +PORTREVISION=3D	1
>  CATEGORIES=3D	devel tcl
> =20
>  MAINTAINER=3D	tcltk@FreeBSD.org
> @@ -13,6 +14,8 @@ LICENSE_NAME=3D	Tcl/Tk License
>  LICENSE_FILE=3D	${WRKSRC}/license.terms
>  LICENSE_PERMS=3D	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept=

> =20
> +BUILD_DEPENDS=3D	critcl:${PORTSDIR}/devel/critcl

=2E..

>  do-install:
>  	cd ${WRKSRC} && ${TCLSH} ./installer.tcl ${INSTALL_ARGS}
> +	${RM} ${WRKSRC}/modules/tcllibc/license.terms
> +	${CP} -Rp ${WRKSRC}/modules/tcllibc ${STAGEDIR}${PREFIX}/lib/tcllib/

=2E..

> +lib/tcllib/tcllibc/%%BINARCH%%/tcllibc.so

Bundling libraries is bad.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/bundle=
d-libs.html

It will also confuse pkg unless BUNDLE_LIBS=3Dyes is added.

Can tcllib not use critcl from its own package?


--=20
Regards,
Bryan Drewery


--3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJVZgFlAAoJEDXXcbtuRpfPqxoIANVmqSf7IkX1tLxtwAYWd8DV
X1qUC/v52mdsu1AXdorofkUmStcdCO3kfBYL3eUguz/0U1MVLLDyYUM31lCxgjwk
1QUxbRnZsECPqYPqcGf7mlGnJZDjCUDGVDx0Hv1Iy1495Mvg7qqbgUW+hQLiRc5a
Dci7qEDRbDivjw3L+uQTFhgC/rt5PwMyQ1oSnnMD6mPAG/nshzZiYHM+MtS8g0ro
jyvC0Jz6raAXFWhgnj1E4xsISkEwW2mzAriJTCxmqY4+ObZdSDyucZ/2djDnd9Jf
ZWRa/++1ypWN0f7RQYO1QWQhm42F0AjC2xmfo1zXweWw+yI/UZT+70HGE3njBOE=
=WwU+
-----END PGP SIGNATURE-----

--3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55660165.3050106>