Date: Tue, 15 Jul 2014 19:37:36 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191884] [PATCH] teach chown and chmod about SIGINFO Message-ID: <bug-191884-8-Y9utEWiHuq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191884-8@https.bugs.freebsd.org/bugzilla/> References: <bug-191884-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191884 Mateusz Guzik <mjg@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjg@FreeBSD.org --- Comment #1 from Mateusz Guzik <mjg@FreeBSD.org> --- I have only small nits to add. for both tools: - no signal.h included - manual pages not updated to reflect new functionality chown: - if (vflag) { verbose(p, vflag); } should loose braces - 'verbose' is not the best name, maybe 'print_info'? Patches for both utils should be attached separately. Care to plug these problems? Other than that looks good to me. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191884-8-Y9utEWiHuq>