Date: Mon, 29 Jan 2001 16:54:34 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Matt Dillon <dillon@earth.backplane.com> Cc: freebsd-hackers@FreeBSD.org, Drew Eckhardt <drew@PoohSticks.ORG> Subject: Re: Suboptimal mmap of devices on i86 Message-ID: <XFMail.010129165434.jhb@FreeBSD.org> In-Reply-To: <200101292345.f0TNj6A79322@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29-Jan-01 Matt Dillon wrote: > I like it, with some minor tweaks. I recommend: > > * name the new function vm_map_findspace2() (or something similarly > short. > > * change all callers of vm_map_findspace() to instead call > vm_map_findspace2() directly. > > * depreciate the original vm_map_findspace() entirely (get rid of > it rather then supplying a compatibility function). > > The name change is to ensure that out of date loadable modules > don't try to use the new function with the wrong arguments. Better > to get a kld error then to crash. > > -Matt Oh yuck. Please do rename the darn thing back at some point then. Or if its only going to be in -current, don't bother. No one expects to be able to use a 4.x module in 5.x, so just change the function w/o the old name. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010129165434.jhb>