Date: Mon, 14 Jan 2019 15:23:51 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: "Jason A. Harmening" <jah@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343005 - head/sys/kern Message-ID: <20190114232351.GS18452@FreeBSD.org> In-Reply-To: <201901132033.x0DKXtin020499@repo.freebsd.org> References: <201901132033.x0DKXtin020499@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jason, thanks a lot for fixing this. On Sun, Jan 13, 2019 at 08:33:55PM +0000, Jason A. Harmening wrote: J> Author: jah J> Date: Sun Jan 13 20:33:54 2019 J> New Revision: 343005 J> URL: https://svnweb.freebsd.org/changeset/base/343005 J> J> Log: J> Handle SIGIO for listening sockets J> J> r319722 separated struct socket and parts of the socket I/O path into J> listening-socket-specific and dataflow-socket-specific pieces. Listening J> socket connection notifications are now handled by solisten_wakeup() instead J> of sowakeup(), but solisten_wakeup() does not currently post SIGIO to the J> owning process. J> J> PR: 234258 J> Reported by: Kenneth Adelman J> MFC after: 1 week J> Differential Revision: https://reviews.freebsd.org/D18664 J> J> Modified: J> head/sys/kern/uipc_socket.c J> J> Modified: head/sys/kern/uipc_socket.c J> ============================================================================== J> --- head/sys/kern/uipc_socket.c Sun Jan 13 19:49:46 2019 (r343004) J> +++ head/sys/kern/uipc_socket.c Sun Jan 13 20:33:54 2019 (r343005) J> @@ -886,6 +886,8 @@ solisten_wakeup(struct socket *sol) J> } J> SOLISTEN_UNLOCK(sol); J> wakeup_one(&sol->sol_comp); J> + if ((sol->so_state & SS_ASYNC) && sol->so_sigio != NULL) J> + pgsigio(&sol->so_sigio, SIGIO, 0); J> } J> J> /* J> -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190114232351.GS18452>