Date: Wed, 16 Apr 1997 03:06:25 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, tejblum@arc.hq.cti.ru Cc: freebsd-bugs@freefall.freebsd.org Subject: Re: misc/3291: md2.h, md4.h, and md5.h headers useless for c++ programms Message-ID: <199704151706.DAA05391@godzilla.zeta.org.au>
index | next in thread | raw e-mail
>> My man page synopsis checker test won't pass :-). > >Sorry, I cannot see the reason :-( I have no your man page synopsis >checker :-( (May be, you don't noticed that md2.3, md4.3, and md5.3 >generated by make from mdX.3 and didn't say 'make' before synopsis check?) Sorry, I didn't notice and change to *.3 in your previous mail (and didn't keep it - phk will have to commit it if he agrees with it). >> BTW, there are bugs >> in the synopsis for MD5.9. The synopsis checker generates the following >> ... > Yes, it seems that MD5Transform is static function in md5c.c. So, >MD5.9 is absolutly wrong. It is from OpenBSD, which apparently does md stuff differently. Our md5.3 can hardly be wrong for MD5.9, since they use the same header file :-). Actually, it is wrong, because using the same header file without KERNEL ifdefs is wrong. This is more obvious when you add __BEGIN_DECLS__ etc. These only apply to functions outside the kernel. Also, not all of the functions are in the kernel. I don't like 4 cloned versions: md2.3, md4.3, md5.3, MD5.9. It takes time to understand that they are essentially the same and more time to understand that MD5.9 is different because it is wrong. Brucehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704151706.DAA05391>