Date: Fri, 14 Apr 2017 13:04:33 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: Ngie Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <7DCBB59B-388F-463D-8FFF-06390E5B5165@gmail.com> In-Reply-To: <CAOtMX2g49C1EqLKOsj6en3B4oaVNQyD3joohFO3QcJTUv1v93Q@mail.gmail.com> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <CAOtMX2gPHWRGiE9UA5AevZz=cTv_qksAWX0H-xRjDEHp0huCVg@mail.gmail.com> <499FA6FF-E691-4941-B96C-3806072D14AA@gmail.com> <CAOtMX2g49C1EqLKOsj6en3B4oaVNQyD3joohFO3QcJTUv1v93Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_9D992930-BC47-4C34-9469-C80D9504EB99 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 13:02, Alan Somers <asomers@freebsd.org> wrote: ... > Right: check_size() needs to know the on-disk size of the core dump. > But it doesn't have any way to know the on-disk size until after it's > written everything to disk. That's why I simply disabled the check at > $WORK. Another possibility would be for savecore to ignore the > up-front check, but handle ENOSPC by deleting the fragmentary vmcore > file. I never tried to implement that. Let me dig through the gzip format a bit. There should be a reasonably = good upper bound approximation that we can use for compressed minidumps. Thanks! -Ngie --Apple-Mail=_9D992930-BC47-4C34-9469-C80D9504EB99 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8StRAAoJEPWDqSZpMIYVHy4P/3WBVmu2EtkkpvcIGCcO/2Bx YGCw021TgUG5BP1YF99gQUwgRaIk0cX6wj1XQxqS+UOyZPmsiyVGA64qF0ExibGt U1D8e8wBx/cz/3i0czH4oWGvboeN3S/5GRPDfPLcXKqqrBJIXw7a58zuS8Zvm6W8 2xHRD6DtxwsPW5RSPYnWcyb0Dvya1Y7U6BnEmirVjlKxbWeQE3zYiVuMvXiPoIUy TSMvO5gKpWuRkvg9uz8Uzl9d0pb6Z6EHm8UI6uUXDq4oZCULCkrG0quloedQTu5m EWRnK6Y6xxXNt1g8zre7/Ivyixs/7JirXVRpiYtSLNT4FOCXbYeF7iFiLdkOpZlN Xffz3wvw4l9a48Z/2gAEHd8D10NdmYMU5sfkykeCJMjHnBL+DScPxZb4HdOD9PDi 1Jj7pfSDZAk3E6FEV6z2i3wOlnwVI/r0UFORDX3M2bPjHCrI4PI6lRMZSiVUSqSE IqvkEMM9iI1twKKbS0F3UF8znbS3SPfX2FJ3WaG21plXMTCGoWU2k0PWIPn1FFHj yMgfTZUnFgvTywsQNVNe1newV663kYZxX0iXB8glmtGmw4nWi+eqcGQWSVJhJsNN A+8uayzrRspjr4RhQfBBirb4JbbNQ5vClkdkvISD0W88m6Nf8YT3iswgzPZwoYBn 96RzsLFZZ9HWLxUvLZze =Q9El -----END PGP SIGNATURE----- --Apple-Mail=_9D992930-BC47-4C34-9469-C80D9504EB99--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7DCBB59B-388F-463D-8FFF-06390E5B5165>